gh-77465: Increase test coverage for numbers
#111738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erlend-aasland
changed the title
numbers
There was a problem hiding this comment.
There is too many code for implementing methods that are not used, just to allow instantiation of the subclass of an abstract class. I suggest to generate them.
import abc
def not_implemented(*args, **kwargs):
raise NotImplementedError
def concretize(cls):
for name in dir(cls):
try:
value = getattr(cls, name)
if value.__isabstractmethod__:
setattr(cls, name, not_implemented)
except AttributeError:
pass
abc.update_abstractmethods(cls)
return clsYou can just apply this decorator to subclasses and remove all dummy methods.
Co-authored-by: Serhiy Storchaka <[email protected]>
|
Thanks for the review, applied! |
Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka
added
needs backport to 3.11
|
Thanks @aisk for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 25, 2024
…GH-111738) (cherry picked from commit e721adf) Co-authored-by: AN Long <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 25, 2024
…GH-111738) (cherry picked from commit e721adf) Co-authored-by: AN Long <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-114556 is a backport of this pull request to the 3.12 branch. |
|
GH-114557 is a backport of this pull request to the 3.11 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Jan 25, 2024
…1738) (GH-114557) (cherry picked from commit e721adf) Co-authored-by: AN Long <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka
added a commit
that referenced
this pull request
Jan 25, 2024
…1738) (GH-114556) (cherry picked from commit e721adf) Co-authored-by: AN Long <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]>
aisk
added a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…GH-111738) Co-authored-by: Serhiy Storchaka <[email protected]>
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…GH-111738) Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most classes in
numbersare ABCs, but they have default implementations for some methods, for example,Complex.__bool__. Although the impementations are simple, but they should have been tested.