Skip to content

gh-111658: Improve parser to accept complicated block of code under interactive REPL #111659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gh-111658: Improve parser to accept complicated block of code under interactive REPL #111659

wants to merge 2 commits into from
+3,037 −2,871

Conversation

hsfzxjy
Copy link

@hsfzxjy hsfzxjy commented Nov 2, 2023 •
edited
Loading

@ghost
Copy link

ghost commented Nov 2, 2023 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app bedevere-app bot mentioned this pull request Nov 2, 2023
Closed
@bedevere-app
Copy link

bedevere-app bot commented Nov 2, 2023

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

terryjreedy
terryjreedy requested changes Nov 2, 2023
View reviewed changes
Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This major change needs a fairly extensive set of new tests.

@bedevere-app
Copy link

bedevere-app bot commented Nov 2, 2023

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@hsfzxjy hsfzxjy force-pushed the improve-parser-repl branch from 66ac455 to 2de5416 Compare November 3, 2023 08:57
@bedevere-app
Copy link

bedevere-app bot commented Nov 3, 2023

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@hsfzxjy hsfzxjy force-pushed the improve-parser-repl branch from 2de5416 to 1604a57 Compare November 3, 2023 09:02
@bedevere-app
Copy link

bedevere-app bot commented Nov 3, 2023

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryjreedy terryjreedy terryjreedy requested changes

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Assignees
No one assigned
Labels
awaiting changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsfzxjy @terryjreedy