Skip to content

gh-109693: Remove pycore_atomic.h #110992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2023
Merged

gh-109693: Remove pycore_atomic.h #110992

merged 1 commit into from
Oct 17, 2023

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Oct 17, 2023 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Oct 17, 2023
Closed
@corona10 corona10 marked this pull request as ready for review October 17, 2023 14:38
@corona10 corona10 requested a review from a team as a code owner October 17, 2023 14:38
@corona10 corona10 merged commit 2dcc570 into python:main Oct 17, 2023
@vstinner
Copy link
Member

Goodbye pycore_atomic.h!

@vstinner
Copy link
Member

Good! Now we only have a single C API for atomic variables:

$ git ls-files|grep atomic
Include/pyatomic.h
Include/cpython/pyatomic.h
Include/cpython/pyatomic_gcc.h
Include/cpython/pyatomic_msc.h
Include/cpython/pyatomic_std.h

Lib/test/test_capi/test_pyatomic.py

Modules/_testcapi/pyatomic.c

@corona10 corona10 deleted the gh-109693-remove-header branch October 17, 2023 23:50
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@corona10 @aisk
pythongh-109693: Remove pycore_atomic.h (pythongh-110992)
cf01e73
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@corona10 @Glyphack
pythongh-109693: Remove pycore_atomic.h (pythongh-110992)
c9f123a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colesbury colesbury colesbury approved these changes

@vstinner vstinner Awaiting requested review from vstinner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@corona10 @vstinner @colesbury