gh-110875: Handle '.' properties in logging formatter configuration c…

[vsajip]

…orrectly.

• Issue: The first attempt to hande the format property during logging.Formatter initilization removes the . dictionary from the config #110875

[AlexWaygood]

Not sure I'm the best reviewer here -- not very familiar with this code, and haven't used logging.Formatter much. But I can try to take a look tomorrow :)

[vsajip]

It's a fairly simple localised change 😄

[encukou]

The same logic is in DictConfigurator.configure_handler as well. Does that need a fix too?

[vsajip]

The same logic is in DictConfigurator.configure_handler as well. Does that need a fix too?

I don't think so, because the . key is popped, if present, just before the equivalent dict comprehension:

cpython/Lib/logging/config.py

Lines 838 to 839 in 20cfab9

	props = config.pop('.', None)
	kwargs = {k: config[k] for k in config if valid_ident(k)}

[encukou]

Well, that's how it was in configure_custom too, before this PR.

[encukou]

PR looks good to me.
If the other site needs to be fixed, it can be done in a different PR. Or this one if you prefer :)

[vsajip]

If the other site needs to be fixed, it can be done in a different PR. Or this one if you prefer :)

I think you're right. Better to make the logic consistent in both places, and it also improves the locality of behavior re. usage of props. Thanks very much for the review!

[miss-islington-app]

Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

[miss-islington-app]

Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

[miss-islington-app]

Sorry, @vsajip, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker a5f29c9faf046b9ef3e498a0bc63dbc29017b5e3 3.11

[bedevere-app]

GH-111911 is a backport of this pull request to the 3.12 branch.

[bedevere-app]

GH-111914 is a backport of this pull request to the 3.11 branch.