Skip to content

DOC: Reuse old bltin-boolean-values ref tag #110371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 4, 2023
Merged

DOC: Reuse old bltin-boolean-values ref tag #110371

merged 4 commits into from
Oct 4, 2023

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Oct 4, 2023 •
edited by github-actions bot
Loading

gh-103487: Reuse old bltin-boolean-values ref tag to avoid breaking downstream intersphinx via numpydoc

The PR is opened as suggested in https://github.com/python/cpython/pull/103487/files#r1346336728 by @hauntsaninja

close astropy/astropy#15428

close numpy/numpydoc#509

📚 Documentation preview 📚: https://cpython-previews--110371.org.readthedocs.build/

@pllim
DOC: Reuse old bltin-boolean-values ref tag
558f91a 
to avoid breaking downstream intersphinx via numpydoc
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Oct 4, 2023
This was referenced Oct 4, 2023
Closed
Merged
pllim and others added 2 commits October 4, 2023 15:36
@pllim
Copy link
Contributor Author

pllim commented Oct 4, 2023

p.s. If you don't want to use the "Squash and merge" button, please let me know so I can clone the repo properly and squash it by hand.

@hauntsaninja hauntsaninja added the needs backport to 3.12 only security fixes label Oct 4, 2023
@AlexWaygood
Copy link
Member

p.s. If you don't want to use the "Squash and merge" button, please let me know so I can clone the repo properly and squash it by hand.

We always use "squash and merge" at CPython, no worries :)

@hauntsaninja hauntsaninja merged commit f786029 into python:main Oct 4, 2023
@miss-islington
Copy link
Contributor

Thanks @pllim for the PR, and @hauntsaninja for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@hauntsaninja
Copy link
Contributor

Thank you!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 4, 2023
@pllim @miss-islington
Add back bltin-boolean-values ref tag (pythonGH-110371)
e87de28 
To avoid breaking downstream intersphinx via numpydoc
(cherry picked from commit f786029)

Co-authored-by: P. L. Lim <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Oct 4, 2023

GH-110372 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 4, 2023
@pllim pllim deleted the patch-1 branch October 4, 2023 19:58
@pllim
Copy link
Contributor Author

pllim commented Oct 4, 2023

Thank you for the quick reviews and resolution!

hauntsaninja pushed a commit that referenced this pull request Oct 4, 2023
@miss-islington @pllim
[3.12] Add back bltin-boolean-values ref tag (GH-110371) (#110372)
36a7d6b 
Add back bltin-boolean-values ref tag (GH-110371)

To avoid breaking downstream intersphinx via numpydoc
(cherry picked from commit f786029)

Co-authored-by: P. L. Lim <[email protected]>
@pllim
Copy link
Contributor Author

pllim commented Oct 5, 2023

By the way, how soon will https://docs.python.org/3/ point to the updated doc with this patch? 👀

@AlexWaygood
Copy link
Member

By the way, how soon will https://docs.python.org/3/ point to the updated doc with this patch? 👀

I think the docs are rebuilt once a day!

@pllim pllim mentioned this pull request Oct 5, 2023
Merged
1 task
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@pllim @Glyphack
Add back bltin-boolean-values ref tag (python#110371)
3b430a9 
To avoid breaking downstream intersphinx via numpydoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood left review comments

@hauntsaninja hauntsaninja Awaiting requested review from hauntsaninja

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
5 participants
@pllim @AlexWaygood @miss-islington @hauntsaninja @JelleZijlstra