-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
gh-109276: regrtest: shorter list of resources #110326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
vstinner
commented
Oct 4, 2023
•
edited by bedevere-app
bot
Loading
edited by bedevere-app
bot
- Issue: Enhance Python regrtest test runner (test.libregrtest) #109276
1376d46
to
73ad79e
Compare
73ad79e
to
68f2ade
Compare
Examples:
|
@serhiy-storchaka: Does it look better like that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not have problems with the older output, but if you want to change it, the new one looks better.
Did you consider the idea of making it compatible with the input to the -u
option? I.e. remove space after comma and remove plus sign. Alternatively you can make -u
accepting input with spaces and pluses (although copying text with spaces is less convenient). Not that I personally need this feature, but it might come in handy one day.
Done.
Done. |
for name in sorted(all_resources - use_resources): | ||
relative_all.append(f'-{name}') | ||
for name in sorted(use_resources - all_resources): | ||
relative_all.append(f'{name}') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
relative_all.append(f'{name}') | |
relative_all.append(name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right. Sadly, I saw your comment after the change was merged. I make try to include it in my next regrtest change ;-)
For me, it's not easy to know if it's default --slow-ci option, default --fast-ci option, or if -u options were modified on a buildbot. With the new output relative to |