gh-110014: Fix inconsistent struct definition in pycore_semaphore.h #110030
Conversation
…re.h The pycore_semaphore.h header is included by Python/lock.c and Python/parking_lot.c. The macro `_POSIX_SEMAPHORES` was not consistently defined across the two files (due to a missing include of `<unistd.h>`) leading to different struct definitions. The RHEL8 ppc64le LTO buildbot correctly warned due to this issue.
|
!buildbot ppc64le |
|
The regex 'ppc64le' did not match any buildbot builder.Is the requested builder in the list of stable builders? |
|
!buildbot lto |
|
The regex 'lto' did not match any buildbot builder.Is the requested builder in the list of stable builders? |
colesbury
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @colesbury for commit 6e0228b 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
|
Oh, maybe the search is case sensitive and you should use |
|
!buildbot PPC64LE |
|
🤖 New build scheduled with the buildbot fleet by @colesbury for commit 6e0228b 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
I wrote python/buildmaster-config#409 to make the search ignores the case. I got bitten multiple times by the |
|
Thanks! |
|
@vstinner, would you please review this when you get a chance? |
There was a problem hiding this comment.
Oh wait. The problem is way wider than pycore_semaphore.h! _POSIX_THREADS and _POSIX_SEMAPHORES macros are checked in Python/pthread_thread.h, pycore_condvar.h. and pycore_pythread.h without explicitly including <unistd.h>.
I wrote a wider change to attempt to fix all cases: PR gh-110139.
|
I wrote a more complete fix: PR #110139. Thanks for working on fixing these warnings! |
The pycore_semaphore.h header is included by Python/lock.c and Python/parking_lot.c. The macro
_POSIX_SEMAPHORESwas not consistently defined across the two files (due to a missing include of<unistd.h>) leading to different struct definitions. The RHEL8 ppc64le LTO buildbot correctly warned due to this issue.