gh-109845: Make test_ftplib more stable under load #109912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
recv() can return partial data cut in the middle of a multibyte character. Test raw binary data instead of data incorrectly decoded by parts.
serhiy-storchaka
added
tests
| @@ -32,7 +32,7 @@ | |||
| DEFAULT_ENCODING = 'utf-8' | |||
| # the dummy data returned by server over the data channel when | |||
| # RETR, LIST, NLST, MLSD commands are issued | |||
| RETR_DATA = 'abcde12345\r\n' * 1000 + 'non-ascii char \xAE\r\n' | |||
| RETR_DATA = 'abcde\xB9\xB2\xB3\xA4\xA6\r\n' * 1000 | |||
There was a problem hiding this comment.
It makes the bug easier reproducible.
|
I confirm that the PR fix the issue. I can easily reproduce the issue with this script in a few seconds: #109845 (comment) With this PR, I can no longer reproduce the issue: |
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 26, 2023
…9912) recv() can return partial data cut in the middle of a multibyte character. Test raw binary data instead of data incorrectly decoded by parts. (cherry picked from commit 2ef2fff) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-109919 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 26, 2023
…9912) recv() can return partial data cut in the middle of a multibyte character. Test raw binary data instead of data incorrectly decoded by parts. (cherry picked from commit 2ef2fff) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-109920 is a backport of this pull request to the 3.11 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Sep 26, 2023
…GH-109920) recv() can return partial data cut in the middle of a multibyte character. Test raw binary data instead of data incorrectly decoded by parts. (cherry picked from commit 2ef2fff) Co-authored-by: Serhiy Storchaka <[email protected]>
|
|
|
|
Fixed by PR #109928. |
csm10495
pushed a commit
to csm10495/cpython
that referenced
this pull request
Sep 28, 2023
…9912) recv() can return partial data cut in the middle of a multibyte character. Test raw binary data instead of data incorrectly decoded by parts.
Yhg1s
pushed a commit
that referenced
this pull request
Oct 2, 2023
…#109919) gh-109845: Make test_ftplib more stable under load (GH-109912) recv() can return partial data cut in the middle of a multibyte character. Test raw binary data instead of data incorrectly decoded by parts. (cherry picked from commit 2ef2fff) Co-authored-by: Serhiy Storchaka <[email protected]>
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…9912) recv() can return partial data cut in the middle of a multibyte character. Test raw binary data instead of data incorrectly decoded by parts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
recv() can return partial data cut in the middle of a multibyte character. Test raw binary data instead of data incorrectly decoded by parts.