gh-109748: Fix venv test_zippath_from_non_installed_posix() #109872

vstinner · 2023-09-25T22:52:41Z

Fix test_zippath_from_non_installed_posix() of test_venv: don't copy pycache/ directories because they can be modified by other Python tests running in parallel.

Issue: test_venv: test_zippath_from_non_installed_posix() failed on aarch64 RHEL8 Refleaks 3.x #109748

Fix test_zippath_from_non_installed_posix() of test_venv: don't copy __pycache__/ sub-directories, because they can be modified by other Python tests running in parallel.

miss-islington · 2023-09-25T23:16:34Z

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

…thonGH-109872) Fix test_zippath_from_non_installed_posix() of test_venv: don't copy __pycache__/ sub-directories, because they can be modified by other Python tests running in parallel. (cherry picked from commit 25bb266) Co-authored-by: Victor Stinner <[email protected]>

bedevere-app · 2023-09-25T23:16:45Z

GH-109873 is a backport of this pull request to the 3.12 branch.

…thonGH-109872) Fix test_zippath_from_non_installed_posix() of test_venv: don't copy __pycache__/ sub-directories, because they can be modified by other Python tests running in parallel. (cherry picked from commit 25bb266) Co-authored-by: Victor Stinner <[email protected]>

bedevere-app · 2023-09-25T23:16:48Z

GH-109874 is a backport of this pull request to the 3.11 branch.

bedevere-bot · 2023-09-25T23:35:11Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 macOS 3.x has failed when building commit 25bb266.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/725/builds/5737) and take a look at the build logs.
Check if the failure is related to this commit (25bb266) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/725/builds/5737

Failed tests:

test.test_concurrent_futures.test_deadlock

Summary of the results of the build (if available):

==

Click to see traceback logs

remote: Enumerating objects: 10, done.        
remote: Counting objects:  10% (1/10)        
remote: Counting objects:  20% (2/10)        
remote: Counting objects:  30% (3/10)        
remote: Counting objects:  40% (4/10)        
remote: Counting objects:  50% (5/10)        
remote: Counting objects:  60% (6/10)        
remote: Counting objects:  70% (7/10)        
remote: Counting objects:  80% (8/10)        
remote: Counting objects:  90% (9/10)        
remote: Counting objects: 100% (10/10)        
remote: Counting objects: 100% (10/10), done.        
remote: Compressing objects:  50% (1/2)        
remote: Compressing objects: 100% (2/2)        
remote: Compressing objects: 100% (2/2), done.        
remote: Total 10 (delta 8), reused 9 (delta 8), pack-reused 0        
From https://github.com/python/cpython
 * branch                  main       -> FETCH_HEAD
Note: switching to '25bb266fc876b344e31e0b5634a4db94912c1aba'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 25bb266fc8 gh-109748: Fix venv test_zippath_from_non_installed_posix() (#109872)
Switched to and reset branch 'main'

./Modules/readline.c:1256:21: warning: incompatible function pointer types assigning to 'Function *' (aka 'int (*)(const char *, int)') from 'int (void)' [-Wincompatible-function-pointer-types]
    rl_startup_hook = on_startup_hook;
                    ^ ~~~~~~~~~~~~~~~
./Modules/readline.c:1258:23: warning: incompatible function pointer types assigning to 'Function *' (aka 'int (*)(const char *, int)') from 'int (void)' [-Wincompatible-function-pointer-types]
    rl_pre_input_hook = on_pre_input_hook;
                      ^ ~~~~~~~~~~~~~~~~~
2 warnings generated.
./Modules/_cursesmodule.c:1336:9: warning: 'is_pad' is only available on macOS 14.0 or newer [-Wunguarded-availability-new]
    if (py_is_pad(self->win)) {
        ^~~~~~~~~~~~~~~~~~~~
./Modules/_cursesmodule.c:1159:29: note: expanded from macro 'py_is_pad'
#define py_is_pad(win)      is_pad(win)
                            ^~~~~~
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/ncurses.h:964:29: note: 'is_pad' has been marked as being introduced in macOS 14.0 here, but the deployment target is macOS 13.6.0
xtern NCURSES_EXPORT(bool) is_pad (const WINDOW *);            /* generated */
                            ^
./Modules/_cursesmodule.c:1336:9: note: enclose 'is_pad' in a __builtin_available check to silence this warning
    if (py_is_pad(self->win)) {
        ^~~~~~~~~~~~~~~~~~~~
./Modules/_cursesmodule.c:1159:29: note: expanded from macro 'py_is_pad'
#define py_is_pad(win)      is_pad(win)
                            ^~~~~~
./Modules/_cursesmodule.c:2024:9: warning: 'is_pad' is only available on macOS 14.0 or newer [-Wunguarded-availability-new]
    if (py_is_pad(self->win)) {
        ^~~~~~~~~~~~~~~~~~~~
./Modules/_cursesmodule.c:1159:29: note: expanded from macro 'py_is_pad'
#define py_is_pad(win)      is_pad(win)
                            ^~~~~~
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/ncurses.h:964:29: note: 'is_pad' has been marked as being introduced in macOS 14.0 here, but the deployment target is macOS 13.6.0
xtern NCURSES_EXPORT(bool) is_pad (const WINDOW *);            /* generated */
                            ^
./Modules/_cursesmodule.c:2024:9: note: enclose 'is_pad' in a __builtin_available check to silence this warning
    if (py_is_pad(self->win)) {
        ^~~~~~~~~~~~~~~~~~~~
./Modules/_cursesmodule.c:1159:29: note: expanded from macro 'py_is_pad'
#define py_is_pad(win)      is_pad(win)
                            ^~~~~~
./Modules/_cursesmodule.c:2248:9: warning: 'is_pad' is only available on macOS 14.0 or newer [-Wunguarded-availability-new]
    if (py_is_pad(self->win)) {
        ^~~~~~~~~~~~~~~~~~~~
./Modules/_cursesmodule.c:1159:29: note: expanded from macro 'py_is_pad'
#define py_is_pad(win)      is_pad(win)
                            ^~~~~~
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/ncurses.h:964:29: note: 'is_pad' has been marked as being introduced in macOS 14.0 here, but the deployment target is macOS 13.6.0
xtern NCURSES_EXPORT(bool) is_pad (const WINDOW *);            /* generated */
                            ^
./Modules/_cursesmodule.c:2248:9: note: enclose 'is_pad' in a __builtin_available check to silence this warning
    if (py_is_pad(self->win)) {
        ^~~~~~~~~~~~~~~~~~~~
./Modules/_cursesmodule.c:1159:29: note: expanded from macro 'py_is_pad'
#define py_is_pad(win)      is_pad(win)
                            ^~~~~~
./Modules/_cursesmodule.c:2324:9: warning: 'is_pad' is only available on macOS 14.0 or newer [-Wunguarded-availability-new]
    if (py_is_pad(self->win)) {
        ^~~~~~~~~~~~~~~~~~~~
./Modules/_cursesmodule.c:1159:29: note: expanded from macro 'py_is_pad'
#define py_is_pad(win)      is_pad(win)
                            ^~~~~~
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/ncurses.h:964:29: note: 'is_pad' has been marked as being introduced in macOS 14.0 here, but the deployment target is macOS 13.6.0
xtern NCURSES_EXPORT(bool) is_pad (const WINDOW *);            /* generated */
                            ^
./Modules/_cursesmodule.c:2324:9: note: enclose 'is_pad' in a __builtin_available check to silence this warning
    if (py_is_pad(self->win)) {
        ^~~~~~~~~~~~~~~~~~~~
./Modules/_cursesmodule.c:1159:29: note: expanded from macro 'py_is_pad'
#define py_is_pad(win)      is_pad(win)
                            ^~~~~~
4 warnings generated.
In file included from ./Modules/_tkinter.c:52:
In file included from /opt/homebrew/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/tk.h:99:
/opt/homebrew/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:131:21: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
        int (*free_private)();  /* called to free private storage */
                           ^
                            void
/opt/homebrew/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:334:33: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
        struct _XImage *(*create_image)();
                                       ^
                                        void
/opt/homebrew/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:453:23: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
        XID (*resource_alloc)(); /* allocator function */
                             ^
                              void
/opt/homebrew/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:471:20: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
        int (*synchandler)();   /* Synchronization handler */
                          ^
                           void
/opt/homebrew/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:496:24: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
        Bool (*event_vec[128])();  /* vector for wire to event */
                              ^
                               void
/opt/homebrew/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:497:25: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
        Status (*wire_vec[128])(); /* vector for event to wire */
                               ^
                                void
/opt/homebrew/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:509:20: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
        Bool (**error_vec)();      /* vector for wire to error */
                          ^
                           void
/opt/homebrew/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:522:25: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
        int (*savedsynchandler)(); /* user synchandler when Xlib usurps */
                               ^
                                void
/opt/homebrew/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:1053:24: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
typedef void (*XIMProc)();
                       ^
                        void
In file included from ./Modules/tkappinit.c:17:
In file included from /opt/homebrew/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/tk.h:99:
/opt/homebrew/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:131:21: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
        int (*free_private)();  /* called to free private storage */
                           ^
                            void
/opt/homebrew/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:334:33: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
        struct _XImage *(*create_image)();
                                       ^
                                        void
/opt/homebrew/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:453:23: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
        XID (*resource_alloc)(); /* allocator function */
                             ^
                              void
/opt/homebrew/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:471:20: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
        int (*synchandler)();   /* Synchronization handler */
                          ^
                           void
/opt/homebrew/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:496:24: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
        Bool (*event_vec[128])();  /* vector for wire to event */
                              ^
                               void
/opt/homebrew/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:497:25: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
        Status (*wire_vec[128])(); /* vector for event to wire */
                               ^
                                void
/opt/homebrew/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:509:20: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
        Bool (**error_vec)();      /* vector for wire to error */
                          ^
                           void
/opt/homebrew/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:522:25: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
        int (*savedsynchandler)(); /* user synchandler when Xlib usurps */
                               ^
                                void
/opt/homebrew/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:1053:24: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
typedef void (*XIMProc)();
                       ^
                        void
9 warnings generated.
9 warnings generated.

make: *** [buildbottest] Error 5

…H-109872) (#109874) gh-109748: Fix venv test_zippath_from_non_installed_posix() (GH-109872) Fix test_zippath_from_non_installed_posix() of test_venv: don't copy __pycache__/ sub-directories, because they can be modified by other Python tests running in parallel. (cherry picked from commit 25bb266) Co-authored-by: Victor Stinner <[email protected]>

…thon#109872) Fix test_zippath_from_non_installed_posix() of test_venv: don't copy __pycache__/ sub-directories, because they can be modified by other Python tests running in parallel.

pythongh-109748: Fix venv test_zippath_from_non_installed_posix()

374e0fe

Fix test_zippath_from_non_installed_posix() of test_venv: don't copy __pycache__/ sub-directories, because they can be modified by other Python tests running in parallel.

vstinner added tests Tests in the Lib/test dir needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Sep 25, 2023

vstinner requested a review from vsajip as a code owner September 25, 2023 22:52

bedevere-app bot added the awaiting review label Sep 25, 2023

bedevere-app bot mentioned this pull request Sep 25, 2023

test_venv: test_zippath_from_non_installed_posix() failed on aarch64 RHEL8 Refleaks 3.x #109748

Closed

vstinner enabled auto-merge (squash) September 25, 2023 22:52

vstinner merged commit 25bb266 into python:main Sep 25, 2023

vstinner deleted the test_venv branch September 25, 2023 23:16

bedevere-app bot removed the awaiting review label Sep 25, 2023

bedevere-app bot removed the needs backport to 3.12 only security fixes label Sep 25, 2023

bedevere-app bot removed the needs backport to 3.11 only security fixes label Sep 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

gh-109748: Fix venv test_zippath_from_non_installed_posix() #109872

gh-109748: Fix venv test_zippath_from_non_installed_posix() #109872

Uh oh!

vstinner commented Sep 25, 2023 •

edited by bedevere-app bot

Loading

Uh oh!

miss-islington commented Sep 25, 2023

Uh oh!

bedevere-app bot commented Sep 25, 2023

Uh oh!

bedevere-app bot commented Sep 25, 2023

Uh oh!

bedevere-bot commented Sep 25, 2023

Uh oh!

Uh oh!

Uh oh!

gh-109748: Fix venv test_zippath_from_non_installed_posix() #109872

gh-109748: Fix venv test_zippath_from_non_installed_posix() #109872

Uh oh!

Conversation

vstinner commented Sep 25, 2023 • edited by bedevere-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

miss-islington commented Sep 25, 2023

Uh oh!

bedevere-app bot commented Sep 25, 2023

Uh oh!

bedevere-app bot commented Sep 25, 2023

Uh oh!

bedevere-bot commented Sep 25, 2023

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Uh oh!

vstinner commented Sep 25, 2023 •

edited by bedevere-app bot

Loading