gh-109782: Ensure os.path.isdir has the same signature on all platforms
#109790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminalaee
force-pushed
the
fix-nt-os-path-isdir-signature
branch
from
0628d63 to
13d10df
Compare
AlexWaygood
changed the title
os.path.isdir has the same signature on all platforms
|
I don't think we need a test for this. More likely we need a written policy somewhere about how named arguments are handled in accelerator functions (which will probably retrigger the discussion about named vs. position-only arguments again). |
This comment was marked as outdated.
This comment was marked as outdated.
|
Thanks! |
|
FYI I'm planning to backport this, but only for 3.12.1 (it's not important enough to be backported this close to the release date for 3.12.0) |
|
Thanks @aminalaee for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Sorry, @aminalaee and @zooba, I could not cleanly backport this to |
|
GH-110233 is a backport of this pull request to the 3.12 branch. |
AlexWaygood
added a commit
that referenced
this pull request
Oct 2, 2023
…l platforms (GH-109790) (#110233) gh-109782: Ensure `os.path.isdir` has the same signature on all platforms (GH-109790) Co-authored-by: Amin Alaee <[email protected]>
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix the
os.path.isdirsignature for Windows to be the same as genericpath version.