gh-109373: Store metadata required for pystats comparison in the json #109374
Conversation
Tools/scripts/summarize_stats.py
Outdated
| def ratio_to_float(s): | ||
| """ | ||
| The inverse of format_ratio. | ||
| """ | ||
| if s == "": | ||
| return 0.0 | ||
| else: | ||
| return float(s[:-1]) | ||
|
|
There was a problem hiding this comment.
This confused me, because it's not the inverse, right? It just turns "4.2%" into 4.2 (which feels wrong to me since I'd expect .042... I know that this is what the old code does, and it's only used as a sort key, so I guess either is fine).
So I'd suggest changing the name and docstring, but I honestly can't think of a good name for this operation...
At least, if this is gonna be its own function, maybe assert s.endswith("%") so it's clear what this function is doing?
There was a problem hiding this comment.
Good point. I renamed the function and clarified in the docstring.
| @@ -179,6 +192,16 @@ def gather_stats(input): | |||
| value = int(value) | |||
| stats[key] += value | |||
| stats['__nfiles__'] += 1 | |||
|
|
|||
| import opcode | |||
There was a problem hiding this comment.
Just curious, why was this import moved here? Just to reduce the temptation to use it elsewhere in the file?
There was a problem hiding this comment.
Yes, exactly. Any use of opcode, dis or other sorts of bytecode introspection things on the "compare two results" path could lead to a subtle, silent error. I'll add a comment.
Uh oh!
There was an error while loading. Please reload this page.