fix variable name in dis documentation
#109343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BINARY_SUBSCR example erroneously uses two different names `key` and `index` to refer to the same variable. STORE_SUBSCR and DELETE_SUBSCR use only `key` in the same context. Changing `index` to `key` for consistency.
|
All commit authors signed the Contributor License Agreement. |
bedevere-app
bot
added
awaiting review
docs
serhiy-storchaka
approved these changes
Sep 13, 2023
|
Thanks @olekskrav for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 13, 2023
BINARY_SUBSCR example erroneously uses two different names `key` and `index` to refer to the same variable. STORE_SUBSCR and DELETE_SUBSCR use only `key` in the same context. Changing `index` to `key` for consistency. (cherry picked from commit a0c06a4) Co-authored-by: Oleksandr Kravets <[email protected]>
|
GH-109364 is a backport of this pull request to the 3.12 branch. |
|
Thank you for your contribution @olekskrav. |
Yhg1s
pushed a commit
that referenced
this pull request
Sep 13, 2023
…09364) Fix variable name in dis documentation example (GH-109343) BINARY_SUBSCR example erroneously uses two different names `key` and `index` to refer to the same variable. STORE_SUBSCR and DELETE_SUBSCR use only `key` in the same context. Changing `index` to `key` for consistency. (cherry picked from commit a0c06a4) Co-authored-by: Oleksandr Kravets <[email protected]>
vstinner
pushed a commit
to vstinner/cpython
that referenced
this pull request
Sep 13, 2023
BINARY_SUBSCR example erroneously uses two different names `key` and `index` to refer to the same variable. STORE_SUBSCR and DELETE_SUBSCR use only `key` in the same context. Changing `index` to `key` for consistency.
|
Thank you all for the quick work on this pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BINARY_SUBSCR opcode explanation erroneously uses two different names
keyandindexto refer to the same variable. STORE_SUBSCR and DELETE_SUBSCR use onlykeyin the same context. Changingindextokeyfor consistency.📚 Documentation preview 📚: https://cpython-previews--109343.org.readthedocs.build/