gh-107211: Fix select extension build on Solaris #108012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
force-pushed
the
export_py_open
branch
from
30ce6fd to
87a1a21
Compare
|
@kulikjak: Can you please check if this change fix your build issue? ref: #107211 (comment) |
Export the internal _Py_open() and _Py_write() functions for Solaris: the select shared extension uses them.
vstinner
force-pushed
the
export_py_open
branch
from
87a1a21 to
dbc8633
Compare
kulikjak
approved these changes
Aug 16, 2023
|
You're welcome. It seems like we have no Solaris buildbot anymore. I'm fine with you reporting issues manually :-) |
|
Thank you. As for the buildbot worker, there is technically a Solaris one I am maintaining, but sadly it's red all the time as there are some Solaris-specific changes that would need to be merged first. I created PRs for most of them some time ago, but they were not merged yet, and ATM they will probably need some rebasing and possibly minor updates to make them mergeable again. Our internal buildbot is green/yellow most of the time, so it's definitely possible. I will look into it again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export the internal _Py_open() function for Solaris: the select extension uses it in its newDevPollObject() function.