[3.12] gh-106242: Fix path truncation in os.path.normpath (GH-106816) #107981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
zooba
commented
Aug 15, 2023
•
zooba
commented
- Issue: os.path.normpath truncates input on null bytes in 3.11, but not 3.10 #106242
This was referenced Aug 15, 2023
* Strings with length from 2**31-1 to 2**32-2 always caused MemoryError, it doesn't matter how much memory is available. * Strings with length exactly 2**32-1 caused OSError. * Strings longer than 2**32-1 characters were truncated due to integer overflow bug. * Strings containing the null character were truncated at the first null character. Now strings longer than 2**31-1 characters caused OverflowError and the null character is allowed.
|
This relies on the fix in #107874 so I picked it into this PR. If the other PR is merged before then it should just disappear. I also pre-backported #107983 to avoid a couple of compiler warnings. @Yhg1s If you're okay with this (and #107874), would be good to have this 3.11 regression fixed in all 3.12 releases. It will get fixed in 3.11, but probably not the end of the world if it lands in 3.12.1. |
|
Up to Thomas what to do with 3.12, I approved the 3.11 change. |
|
#107874 was merged, so this needs double-checking that it's not unnecessarily (now) duplicating things. It's fine to get this into 3.12. |
|
After the merge it's back down to the original change, so looks good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.