gh-56166: Deprecate passing confusing positional arguments in re functions #107778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e functions Deprecate passing optional arguments maxsplit, count and flags in module-level functions re.split(), re.sub() and re.subn() as positional. They should only be passed by keyword.
serhiy-storchaka
force-pushed
the
re-deprecate-positional-args
branch
from
d7238ab to
862a379
Compare
hauntsaninja
approved these changes
Aug 8, 2023
|
Thank you! |
miketheman
added a commit
to miketheman/pytest-postgresql
that referenced
this pull request
Dec 26, 2024
In Python 3.13, usage of a positional argument for `maxsplit` has been formally deprecated. Refs: python/cpython#107778 Signed-off-by: Mike Fiedler <[email protected]>
1 task
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Feb 25, 2025
…/third_party/crashpad/update.py:231: DeprecationWarning: 'count' is passed as positional argument readme_content_new = re.sub( https://docs.python.org/3/library/re.html: > Deprecated since version 3.13: Passing count and flags as positional > arguments is deprecated. In future Python versions they will be > keyword-only parameters. python/cpython#56166, python/cpython#107778, https://docs.python.org/3/whatsnew/3.13.html#:~:text=gh%2D66543.)-,re%3A,-Deprecate%20passing%20the Change-Id: Id7909960a107163753ccceb5ebe66c639fe02833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6297851 Commit-Queue: Peter Boström <[email protected]> Auto-Submit: Mark Mentovai <[email protected]> Reviewed-by: Peter Boström <[email protected]> Cr-Commit-Position: refs/heads/main@{#1424251}
hubot
pushed a commit
to chromium/crashpad
that referenced
this pull request
Feb 25, 2025
https://docs.python.org/3/library/re.html: > Deprecated since version 3.13: Passing count and flags as positional > arguments is deprecated. In future Python versions they will be > keyword-only parameters. python/cpython#56166, python/cpython#107778, https://docs.python.org/3/whatsnew/3.13.html#:~:text=gh%2D66543.)-,re%3A,-Deprecate%20passing%20the Change-Id: Ibda1394927062dd9e0353e2b9d643b510070deb6 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/6298792 Reviewed-by: Leonard Grey <[email protected]> Commit-Queue: Mark Mentovai <[email protected]>
gm4sl
pushed a commit
to backtrace-labs/crashpad
that referenced
this pull request
Apr 1, 2025
https://docs.python.org/3/library/re.html: > Deprecated since version 3.13: Passing count and flags as positional > arguments is deprecated. In future Python versions they will be > keyword-only parameters. python/cpython#56166, python/cpython#107778, https://docs.python.org/3/whatsnew/3.13.html#:~:text=gh%2D66543.)-,re%3A,-Deprecate%20passing%20the Change-Id: Ibda1394927062dd9e0353e2b9d643b510070deb6 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/6298792 Reviewed-by: Leonard Grey <[email protected]> Commit-Queue: Mark Mentovai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate passing optional arguments maxsplit, count and flags in module-level functions re.split(), re.sub() and re.subn() as positional. They should only be passed by keyword.
📚 Documentation preview 📚: https://cpython-previews--107778.org.readthedocs.build/