Skip to content

[3.12] gh-107630: Revert "[3.12] gh-107080: Fix Py_TRACE_REFS Crashes Under Isolated Subinterpreters (gh-107567) (#107599)" #107648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2023
Merged

[3.12] gh-107630: Revert "[3.12] gh-107080: Fix Py_TRACE_REFS Crashes Under Isolated Subinterpreters (gh-107567) (#107599)" #107648

merged 1 commit into from
Aug 5, 2023

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Aug 4, 2023 •
edited
Loading

@bedevere-bot bedevere-bot mentioned this pull request Aug 4, 2023
Closed
@ericsnowcurrently ericsnowcurrently changed the title Revert "[3.12] gh-107080: Fix Py_TRACE_REFS Crashes Under Isolated Subinterpreters (gh-107567) (#107599)" gh-107630: Revert "[3.12] gh-107080: Fix Py_TRACE_REFS Crashes Under Isolated Subinterpreters (gh-107567) (#107599)" Aug 4, 2023
@bedevere-bot bedevere-bot mentioned this pull request Aug 4, 2023
Closed
@ericsnowcurrently
Copy link
Member Author

@Yhg1s, I didn't see a PR from you already, so I figured I'd make one.

@Yhg1s Yhg1s changed the title gh-107630: Revert "[3.12] gh-107080: Fix Py_TRACE_REFS Crashes Under Isolated Subinterpreters (gh-107567) (#107599)" [3.12] gh-107630: Revert "[3.12] gh-107080: Fix Py_TRACE_REFS Crashes Under Isolated Subinterpreters (gh-107567) (#107599)" Aug 5, 2023
@bedevere-bot bedevere-bot mentioned this pull request Aug 5, 2023
Merged
@Yhg1s Yhg1s merged commit 6e4eec7 into python:3.12 Aug 5, 2023
@ericsnowcurrently ericsnowcurrently deleted the revert-tracerefs-fix branch August 7, 2023 14:56
ericsnowcurrently added a commit to ericsnowcurrently/cpython that referenced this pull request Aug 7, 2023
@ericsnowcurrently
Unrevert "[3.12] pythongh-107080: Fix Py_TRACE_REFS Crashes Under Iso…
6f8b84f 
…lated Subinterpreters (pythongh-107567) (python#107599)".

This reverts commit 6e4eec7 (pythongh-107648).
This was referenced Aug 7, 2023
Closed
Merged
Yhg1s pushed a commit that referenced this pull request Aug 16, 2023
@ericsnowcurrently
[3.12] gh-107080: Fix Py_TRACE_REFS Crashes Under Isolated Subinterpr…
aa9707d 
…eters (#107751)

* Unrevert "[3.12] gh-107080: Fix Py_TRACE_REFS Crashes Under Isolated Subinterpreters (gh-107567) (#107599)".

This reverts commit 6e4eec7 (gh-107648).

* Initialize each interpreter's refchain properly.

* Skip test_basic_multiple_interpreters_deleted_no_reset on tracerefs builds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Yhg1s Yhg1s

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericsnowcurrently @Yhg1s @bedevere-bot