Skip to content

gh-107526: Revert "gh-100357: Convert several functions in bltinsmodule to AC" #107542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 21, 2023
Merged

gh-107526: Revert "gh-100357: Convert several functions in bltinsmodule to AC" #107542

merged 6 commits into from
Aug 21, 2023

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Aug 1, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Aug 1, 2023
Closed
JelleZijlstra
JelleZijlstra reviewed Aug 1, 2023
View reviewed changes
Python/bltinmodule.c Outdated
if (!PyArg_UnpackTuple(args, "vars", 0, 1, &v))
return NULL;
if (v == NULL) {
d = Py_XNewRef(PyEval_GetLocals());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should use _PyEval_GetFrameLocals (I think that's what's causing the test failures; maybe there's similar issues in dir() and locals()).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've missed it.

@sobolevn sobolevn requested a review from JelleZijlstra August 17, 2023 07:18
@JelleZijlstra JelleZijlstra added the needs backport to 3.12 only security fixes label Aug 21, 2023
@JelleZijlstra JelleZijlstra merged commit db6dc6c into python:main Aug 21, 2023
@miss-islington
Copy link
Contributor

Thanks @sobolevn for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @sobolevn and @JelleZijlstra, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker db6dc6ce41f42ec2cb4fdfbc0a099114f42e888f 3.12

@JelleZijlstra
Copy link
Member

@sobolevn could you make a 3.12 backport?

@xncbf
Copy link
Contributor

xncbf commented Aug 21, 2023 •
edited
Loading

It seems that the workflow is broken starting from this PR.
https://github.com/python/cpython/actions/workflows/build.yml

He's working here! ignore it #108187

@hugovk
Copy link
Member

hugovk commented Feb 20, 2025

Triage: Is the 3.12 backport still needed? If not, let's remove the label.

@sobolevn
Copy link
Member Author

Yes, 3.12 backport is still needed. Working on it.

sobolevn added a commit to sobolevn/cpython that referenced this pull request Feb 20, 2025
@sobolevn
[3.12] pythongh-107526: Revert "pythongh-100357: Convert several func…
54efeaf 
…tions in bltinsmodule to AC" (pythonGH-107542)
@bedevere-app
Copy link

bedevere-app bot commented Feb 20, 2025

GH-130371 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Feb 20, 2025
sobolevn added a commit that referenced this pull request Feb 26, 2025
@sobolevn
[3.12] gh-107526: Revert "gh-100357: Convert several functions in blt…
f841099 
…insmodule to AC" (GH-107542) (#130371)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees

@JelleZijlstra JelleZijlstra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sobolevn @miss-islington @JelleZijlstra @xncbf @hugovk @bedevere-bot