Skip to content

[3.11] GH-97950: Fix old-style index directive in Doc/library/imp.rst #107246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

mattwang44
Copy link
Contributor

@mattwang44 mattwang44 commented Jul 25, 2023

I found the following message when building 3.11 doc:

Warning, treated as error:
'statement' is deprecated for index entries (from entry 'statement: import'). Use 'pair: statement; import' instead.

It's part of sphinx-doc/sphinx#11412 and was released with sphinx 7.1.0 yesterday.

@AA-Turner resolved most issues in #104162 (and its 3.11 backport PR is #104163). However, imp module was removed in 3.12 before that and the old index directive in library/imp.rst seems to be omitted.


📚 Documentation preview 📚: https://cpython-previews--107246.org.readthedocs.build/

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Jul 25, 2023
@mattwang44 mattwang44 force-pushed the old-index-directives-in-library-imp branch from d1f419e to 9158f63 Compare July 25, 2023 14:15
@mattwang44 mattwang44 changed the title GH-97950: Use new-style index directive (Doc/library/[email protected]) GH-97950: Use new-style index directive in Doc/library/[email protected] Jul 25, 2023
@mattwang44 mattwang44 changed the title GH-97950: Use new-style index directive in Doc/library/[email protected] [3.11] GH-97950: Use new-style index directive in Doc/library/imp.rst Jul 25, 2023
@mattwang44 mattwang44 changed the title [3.11] GH-97950: Use new-style index directive in Doc/library/imp.rst [3.11] GH-97950: Fix old-style index directive in Doc/library/imp.rst Jul 25, 2023
@mattwang44 mattwang44 force-pushed the old-index-directives-in-library-imp branch from 9158f63 to 7c3d6ae Compare July 26, 2023 02:26
@AA-Turner
Copy link
Member

cc: @hugovk @ezio-melotti

@hugovk hugovk added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 26, 2023
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hugovk hugovk merged commit 9fa44d7 into python:3.11 Jul 26, 2023
@miss-islington
Copy link
Contributor

Thanks @mattwang44 for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @mattwang44 and @hugovk, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 9fa44d7a3045f4571e2cabd53a1cc0f16a0f3723 3.12

@miss-islington
Copy link
Contributor

Sorry, @mattwang44 and @hugovk, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 9fa44d7a3045f4571e2cabd53a1cc0f16a0f3723 3.11

@hugovk
Copy link
Member

hugovk commented Jul 26, 2023

Ignore those two Miss Islington messages, this obviously doesn't need back porting to 3.12 and 3.11 branches because this went straight to 3.11 only.

Thanks again!

@hugovk hugovk removed needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 26, 2023
@hugovk hugovk removed their assignment Jul 26, 2023
@mattwang44 mattwang44 deleted the old-index-directives-in-library-imp branch July 26, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants