Skip to content

gh-106882: asyncio.Server add version changed message for exposure from asyncio.base_events.Server #106901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 19, 2023
Merged

gh-106882: asyncio.Server add version changed message for exposure from asyncio.base_events.Server #106901

merged 2 commits into from
Jul 19, 2023

Conversation

jack60612
Copy link
Contributor

@jack60612 jack60612 commented Jul 19, 2023 •
edited by github-actions bot
Loading

Key Info

This makes sure that the docs clearly show that in earlier versions of Python asyncio.Server could not be imported as such and was instead asyncio.base_events.Server.

Related PR's:
#31760

📚 Documentation preview 📚: https://cpython-previews--106901.org.readthedocs.build/

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Jul 19, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 19, 2023
Closed
@ghost
Copy link

ghost commented Jul 19, 2023 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@jack60612
Copy link
Contributor Author

Hey the CLA bot thingy threw a 500 error a couple times, might want to look into that.

@jack60612
Copy link
Contributor Author

Do i make the backport pr's after this gets merged?

AlexWaygood
AlexWaygood reviewed Jul 19, 2023
View reviewed changes
@AlexWaygood
Copy link
Member

Do i make the backport pr's after this gets merged?

Our loyal bot @miss-islington will take care of that for you :-)

@jack60612
Copy link
Contributor Author

Do i make the backport pr's after this gets merged?

Our loyal bot @miss-islington will take care of that for you :-)

ooh automation 🥳

AlexWaygood
AlexWaygood approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me! Assuming the docs preview doesn't show any unexpected horrors, will merge once the CI has finished :-)

@AlexWaygood
Copy link
Member

AlexWaygood commented Jul 19, 2023 •
edited
Loading

Doc preview LGTM: https://cpython-previews--106901.org.readthedocs.build/en/106901/library/asyncio-eventloop.html#asyncio.Server

@jack60612
Copy link
Contributor Author

Thanks, looks good to me! Assuming the docs preview doesn't show any unexpected horrors, will merge once the CI has finished :-)

No, thank you for making this so easy, I thought this would be a long bureaucratic process, and you made it really easy.

@AlexWaygood AlexWaygood merged commit 1e1f4e9 into python:main Jul 19, 2023
@miss-islington
Copy link
Contributor

Thanks @jack60612 for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-106902 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 19, 2023
@bedevere-bot
Copy link

GH-106903 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 19, 2023
@jack60612 @miss-islington
pythongh-106882: Note that asyncio.Server is only publicly exposed …
b2da942 
…on 3.11+ (pythonGH-106901)

And later versions of 3.10, 3.9
(cherry picked from commit 1e1f4e9)

Co-authored-by: Jack Nelson <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 19, 2023
@jack60612 @miss-islington
pythongh-106882: Note that asyncio.Server is only publicly exposed …
1e4cc54 
…on 3.11+ (pythonGH-106901)

And later versions of 3.10, 3.9
(cherry picked from commit 1e1f4e9)

Co-authored-by: Jack Nelson <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 19, 2023
AlexWaygood pushed a commit that referenced this pull request Jul 19, 2023
@miss-islington @jack60612
[3.11] gh-106882: Note that asyncio.Server is only publicly exposed…
a6313d7 
… on 3.11+ (GH-106901) (#106903)

gh-106882: Note that `asyncio.Server` is only publicly exposed on 3.11+ (GH-106901)

And later versions of 3.10, 3.9
(cherry picked from commit 1e1f4e9)

Co-authored-by: Jack Nelson <[email protected]>
AlexWaygood pushed a commit that referenced this pull request Jul 19, 2023
@miss-islington @jack60612
[3.12] gh-106882: Note that asyncio.Server is only publicly exposed…
c16cf9b 
… on 3.11+ (GH-106901) (#106902)

gh-106882: Note that `asyncio.Server` is only publicly exposed on 3.11+ (GH-106901)

And later versions of 3.10, 3.9
(cherry picked from commit 1e1f4e9)

Co-authored-by: Jack Nelson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news topic-asyncio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jack60612 @AlexWaygood @miss-islington @bedevere-bot