-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
gh-106799: Pick another example method for Argument Clinic How-To #106800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Dong-hee Na <[email protected]>
Hi @erlend-aasland, I know you are interested in AC. Could you take a look at the PR. Is it necessary to change the example used in the article. Thank you very much. |
Hi, @littlebutt! I've already added Alex and myself as reviewers. I'll try to review it within this week. If not, feel free to ping me :) |
Also, it is very nice to see some interest in improving the clinic docs! |
Thank you! |
Hi @erlend-aasland , I modify the origin function to fit all cases in the document. Is it okay with you? Also, I changed some examples before the converter step. Because readers will confuse when they meet converter ahead of its introduction. |
@littlebutt, I worry that this change is premature; the clinic tutorial definitely needs an overhaul, but I think we need to do some basic adjustments before we get to the part where we tear out the existing example. I started doing some adjustments to the clinic docs in small steps (see #106876 and #106904). Here's a very course plan:
What do you think? :) |
It sounds like a good idea. The tutorial needs improvement and a single PR obviously cannot change a lot. More effort should be made to optimize the document. |
The Argument Clinic docs have moved to https://github.com/python/devguide. Please open a new PR over there. |
📚 Documentation preview 📚: https://cpython-previews--106800.org.readthedocs.build/