Skip to content

gh-106799: Pick another example method for Argument Clinic How-To #106800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from

Conversation

littlebutt
Copy link
Contributor

@littlebutt littlebutt commented Jul 16, 2023

  • Pick another example method for Argument Clinic How-To

📚 Documentation preview 📚: https://cpython-previews--106800.org.readthedocs.build/

@littlebutt
Copy link
Contributor Author

Hi @erlend-aasland, I know you are interested in AC. Could you take a look at the PR. Is it necessary to change the example used in the article. Thank you very much.

@erlend-aasland
Copy link
Contributor

Hi, @littlebutt! I've already added Alex and myself as reviewers. I'll try to review it within this week. If not, feel free to ping me :)

@erlend-aasland
Copy link
Contributor

Also, it is very nice to see some interest in improving the clinic docs!

@littlebutt
Copy link
Contributor Author

Hi, @littlebutt! I've already added Alex and myself as reviewers. I'll try to review it within this week. If not, feel free to ping me :)

Thank you!

@littlebutt
Copy link
Contributor Author

Hi @erlend-aasland , I modify the origin function to fit all cases in the document. Is it okay with you? Also, I changed some examples before the converter step. Because readers will confuse when they meet converter ahead of its introduction.

@erlend-aasland
Copy link
Contributor

cc. @serhiy-storchaka @ezio-melotti

@erlend-aasland
Copy link
Contributor

@littlebutt, I worry that this change is premature; the clinic tutorial definitely needs an overhaul, but I think we need to do some basic adjustments before we get to the part where we tear out the existing example. I started doing some adjustments to the clinic docs in small steps (see #106876 and #106904).

Here's a very course plan:

  1. get rid of the numbered list
  2. in multiple steps, align the language of the tutorial with the Diátaxis recommendations -- hopefully, it will shrink in size :)
  3. start reworking the example used in the tutorial (this PR!)

What do you think? :)

@littlebutt
Copy link
Contributor Author

@littlebutt, I worry that this change is premature; the clinic tutorial definitely needs an overhaul, but I think we need to do some basic adjustments before we get to the part where we tear out the existing example. I started doing some adjustments to the clinic docs in small steps (see #106876 and #106904).

Here's a very course plan:

  1. get rid of the numbered list

  2. in multiple steps, align the language of the tutorial with the Diátaxis recommendations -- hopefully, it will shrink in size :)

  3. start reworking the example used in the tutorial (this PR!)

What do you think? :)

It sounds like a good idea. The tutorial needs improvement and a single PR obviously cannot change a lot. More effort should be made to optimize the document.

@erlend-aasland
Copy link
Contributor

The Argument Clinic docs have moved to https://github.com/python/devguide. Please open a new PR over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants