Skip to content

gh-106350: do not ignore return value of mp_init() #106351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 25, 2023

Conversation

chrstphrchvz
Copy link
Contributor

@chrstphrchvz chrstphrchvz commented Jul 3, 2023

@erlend-aasland
Copy link
Contributor

Can you make the PR title a little bit more explanatory? For example: "gh-106350: Detect memory failures in _tkinter.tkapp.call()"

@serhiy-storchaka serhiy-storchaka added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 25, 2023
@serhiy-storchaka serhiy-storchaka merged commit b5ae7c4 into python:main Jul 25, 2023
@miss-islington
Copy link
Contributor

Thanks @chrstphrchvz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

GH-107258 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 25, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 25, 2023
@bedevere-bot
Copy link

GH-107259 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 25, 2023
@serhiy-storchaka
Copy link
Member

It is not only in _tkinter.tkapp.call().

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 25, 2023
@chrstphrchvz chrstphrchvz deleted the patch-1 branch July 25, 2023 19:13
serhiy-storchaka pushed a commit that referenced this pull request Jul 26, 2023
serhiy-storchaka pushed a commit that referenced this pull request Jul 26, 2023
jtcave pushed a commit to jtcave/cpython that referenced this pull request Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants