Skip to content

gh-106107: document correct error that's raised when a mutable default value for a field is detected #106109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2023
Merged

gh-106107: document correct error that's raised when a mutable default value for a field is detected #106109

merged 1 commit into from
Jun 26, 2023

Conversation

rschupp
Copy link
Contributor

@rschupp rschupp commented Jun 26, 2023 •
edited by github-actions bot
Loading

Note that incorrect documentation is present in all python versions since the implementation of dataclasses (in 3.7)

📚 Documentation preview 📚: https://cpython-previews--106109.org.readthedocs.build/

@rschupp rschupp requested a review from ericvsmith as a code owner June 26, 2023 14:57
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Jun 26, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 26, 2023
Closed
@ghost
Copy link

ghost commented Jun 26, 2023 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@ericvsmith ericvsmith added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jun 26, 2023
@ericvsmith ericvsmith added needs backport to 3.12 only security fixes and removed needs backport to 3.10 only security fixes labels Jun 26, 2023
@ericvsmith ericvsmith merged commit 512f299 into python:main Jun 26, 2023
@miss-islington
Copy link
Contributor

Thanks @rschupp for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 26, 2023
@rschupp @miss-islington
pythongh-106107: document correct error that's raised when a mutable …
05f1413 
…default value for a field is detected (pythongh-106109)

(cherry picked from commit 512f299)

Co-authored-by: Roderich Schupp <[email protected]>
@bedevere-bot
Copy link

GH-106115 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 26, 2023
@rschupp @miss-islington
pythongh-106107: document correct error that's raised when a mutable …
8f2eb66 
…default value for a field is detected (pythongh-106109)

(cherry picked from commit 512f299)

Co-authored-by: Roderich Schupp <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 26, 2023
@bedevere-bot
Copy link

GH-106116 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 26, 2023
ericvsmith pushed a commit that referenced this pull request Jun 26, 2023
@miss-islington @rschupp
[3.11] gh-106107: document correct error that's raised when a mutable…
97cf029 
… default value for a field is detected (gh-106109) (gh-106116)

gh-106107: document correct error that's raised when a mutable default value for a field is detected (gh-106109)
(cherry picked from commit 512f299)

Co-authored-by: Roderich Schupp <[email protected]>
ericvsmith pushed a commit that referenced this pull request Jun 26, 2023
@miss-islington @rschupp
[3.12] gh-106107: document correct error that's raised when a mutable…
ea6a4b7 
… default value for a field is detected (gh-106109) (gh-106115)

gh-106107: document correct error that's raised when a mutable default value for a field is detected (gh-106109)
(cherry picked from commit 512f299)

Co-authored-by: Roderich Schupp <[email protected]>
@miss-islington
Copy link
Contributor

Thanks @rschupp for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Thanks @rschupp for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @rschupp for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @rschupp and @ericvsmith, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 512f299e557f4ab60768d36cee9968bd92116367 3.11

@miss-islington
Copy link
Contributor

Sorry, @rschupp and @ericvsmith, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 512f299e557f4ab60768d36cee9968bd92116367 3.10

@miss-islington
Copy link
Contributor

Sorry, @rschupp and @ericvsmith, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 512f299e557f4ab60768d36cee9968bd92116367 3.12

@rschupp rschupp deleted the doc-dataclasses branch June 27, 2023 14:07
@picnixz
Copy link
Member

picnixz commented Sep 14, 2024

Apparently, 3.10 never got its backport (but I'm still removing its label)

@picnixz picnixz removed needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunmy2019 sunmy2019 sunmy2019 approved these changes

@Eclips4 Eclips4 Eclips4 approved these changes

@ericvsmith ericvsmith Awaiting requested review from ericvsmith ericvsmith is a code owner

Assignees

@ericvsmith ericvsmith

Labels
awaiting core review docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rschupp @miss-islington @bedevere-bot @picnixz @sunmy2019 @Eclips4 @ericvsmith