gh-106030: Miscellaneous fixes in Python/suggestions.c #106031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
serhiy-storchaka
commented
Jun 23, 2023
•
serhiy-storchaka
commented
- PyDict_GetItem() and PyObject_HasAttr() suppress arbitrary errors and should not be used.
- PyUnicode_CompareWithASCIIString() only works if the second argument is ASCII string.
- Refleak in get_suggestions_for_name_error.
- Use of borrowed pointer after possible freeing (self).
- Add some missing error checks.
- Issue: Miscellaneous fixes in Python/suggestions.c #106030
* PyDict_GetItem() and PyObject_HasAttr() suppress arbitrary errors and should not be used. * PyUnicode_CompareWithASCIIString() only works if the second argument is ASCII string. * Refleak in get_suggestions_for_name_error. * Use of borrowed pointer after possible freeing (self). * Add some missing error checks.
serhiy-storchaka
force-pushed
the
suggestions
branch
from
3d6655d to
c82f8b8
Compare
AlexWaygood
changed the title
serhiy-storchaka
added
skip news
needs backport to 3.11
pablogsal
approved these changes
Jun 23, 2023
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 23, 2023
…H-106031) * PyDict_GetItem() and PyObject_HasAttr() suppress arbitrary errors and should not be used. * PyUnicode_CompareWithASCIIString() only works if the second argument is ASCII string. * Refleak in get_suggestions_for_name_error. * Use of borrowed pointer after possible freeing (self). * Add some missing error checks. (cherry picked from commit c8c162e) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-106036 is a backport of this pull request to the 3.12 branch. |
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Jun 23, 2023
…ythonGH-106031) * PyDict_GetItem() and PyObject_HasAttr() suppress arbitrary errors and should not be used. * PyUnicode_CompareWithASCIIString() only works if the second argument is ASCII string. * Refleak in get_suggestions_for_name_error. * Use of borrowed pointer after possible freeing (self). * Add some missing error checks.. (cherry picked from commit c8c162e) Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Jun 23, 2023
…ythonGH-106031) * PyUnicode_CompareWithASCIIString() only works if the second argument is ASCII string. * Refleak in get_suggestions_for_name_error. * Add some missing error checks.. (cherry picked from commit c8c162e) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-106039 is a backport of this pull request to the 3.11 branch. |
hauntsaninja
pushed a commit
that referenced
this pull request
Jun 27, 2023
) (#106036) Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.