-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
gh-104773: PEP 594: Remove the nntplib module #104894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc @mcepl |
For those who might be interested in this module, let’s continue with the fun on https://git.sr.ht/~mcepl/nntplib (and on PyPI as https://pypi.org/project/nntplib/). |
* socket_helper.transient_internet() no longer imports nntplib to catch nntplib.NNTPTemporaryError. * ssltests.py no longer runs test_nntplib. * "make quicktest" no longer runs test_nntplib. * WASM: remove nntplib from OMIT_NETWORKING_FILES. * Remove mentions to nntplib in the email documentation.
Thanks @mcepl for having created nntplib on PyPi and making it still alive :) And thanks @vstinner too for all your work on Python! |
Running a CI on a live server is hard. Each time that the server is busy, being upgraded, or has some network issues, the test fails. Sadly, no one managed to modify test_nntplib to tolerate temporary server/network issues. IMO it's better to maintain such project outside Python to ease contributions. These days, |
If you look carefully to my PR, you will see that I recommend this replacement in What's New in Python 3.13, where the removal is documented ;-) |
Using zipfile36 only uses
https://pypi.org/project/zipfile36/ is a backport of the zipfile module from Python 3.6 "which contains some improvements". Suggested usage:
I suppose that Python 3.13 users are not supposed to use a backport of the Python 3.6 zipfile module :-) |
Thanks! |
I use it in my https://pypi.org/project/pygn/ (which certainly isn’t in any Top anything ;)). |
Maybe add a requirement to your own PyPI nntplib module? :-) (with a env markers to only install it on Python 3.13 and newer). |
Any patches are hugely welcome! Especially if somebody helped with mocking out the servers. It doesn't make a sense to run the test suite against real servers. |
How can the module be under the BSD license, as it was copied from the stdlib that’s under the Python license? (not the same thing as the PSF license) |
You are right, I have to investigate this https://todo.sr.ht/~mcepl/pygn/9 Hmm, except https://docs.python.org/3/license.html#psf-license-agreement-for-python-release really doesn’t read like something which could be used outside of the Python 3.11 itself. Does anybody have any good example of a stand-alone Python module which would be licensed under PSF License? |
Via https://pypi.org/classifiers/ here's the PyPI packages with the "License :: OSI Approved :: Python License (CNRI Python License" Trove classifier: (There's also a PSF licence one, but I guess you need Python licence.) |
Any comments on https://git.sr.ht/~mcepl/nntplib/commit/4cb431e3e40d ? |
📚 Documentation preview 📚: https://cpython-previews--104894.org.readthedocs.build/