Skip to content

gh-104773: PEP 594: Remove the pipes module #104848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 24, 2023
Merged

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented May 24, 2023

@vstinner vstinner changed the title gh-104773: PEP 594: Remove pipes module gh-104773: PEP 594: Remove the pipes module May 24, 2023
@hugovk
Copy link
Member

hugovk commented May 24, 2023

The doctest failure is unrelated, here's a PR to fix it: #104852

@vstinner
Copy link
Member Author

@AlexWaygood: Why did you merged the branch 'main' into remove_pipes? I created this PR 49 minutes ago. Do you expect regressions since main changed in the meanwhile? I was awaiting CI tests to complete, and with this merge I have to wait 30 minutes again :-(

@hugovk
Copy link
Member

hugovk commented May 24, 2023

I expect it's to include the doctest fix #104852 from main, so we can get a nice clean (green) slate here.

@AlexWaygood
Copy link
Member

AlexWaygood commented May 24, 2023

@vstinner sorry if I was unhelpful. The doctest CI check was failing on this PR for an unrelated reason; after Hugo merged his fix for the doctest failure into main, I thought I could retrigger the check for you here by merging main into this PR branch. But, since it wasn't a "required" check, you probably could have merged the PR anyway, despite the CI check being red. My bad — sorry again :-)

@hugovk
Copy link
Member

hugovk commented May 24, 2023

By the way, we've now made available GitHub's "Enable auto-merge" feature for this repo, so this could be a good opportunity to give it a spin:

https://devguide.python.org/getting-started/git-boot-camp/#accepting-and-merging-a-pull-request

@vstinner
Copy link
Member Author

The doctest CI check was failing on this PR

Oh, I didn't see. In that case, thank you :-) I was just surprised to see a merge without any explanation.

@AlexWaygood
Copy link
Member

I was just surprised to see a merge without any explanation.

Apologies — I'll explain my actions next time 😄

@vstinner vstinner merged commit a4b7e9d into python:main May 24, 2023
@vstinner vstinner deleted the remove_pipes branch May 24, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants