-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
GH-104395: Add a link in 'Meta Information' to the docs download page #104443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I have no opinion at the moment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Thanks for your PR, @AA-Turner . I just would like to do a suggestion more. Download sounds more related to "Reporting bugs" and "Contributing to Docs" items than "History" and "Copyright" ones. By other hand, "About" seems more related to this latest. So, I suggest: First column:
Second column:
Maybe this can be a little detail, but it do more sense for me as a user. |
FWIW, the other items have rather strange, distracting and inconstant case (sentence/title), phrasing (Docs/documentation, "of Python" or not) and ordering (should most logically be About, History, Copyright), but if we're adding this one, may as well at least add it where it makes the most sense. |
@CAM-Gerlach I agree with you. But one point more. Maybe "History and License" is in wrong section, because the others items are about documentation (meta information), but it is about Python itself. So, what if move this item to "Parts of documentation" section? |
Feel strange that on the top left we have "Download these documents" and at the bottom "Download the documentation", should the wording be unified? I'm also not a fan to duplicate this link, should it really be duplicated, or just moved out of the sidebar? While we're at it: should the sidebar be kept at all? The version picker already exists on the top of the page, and maybe other things can be moved. It would provide more space for the main page, allowing to make it more user friendly. I remember when I started Python I "feared" this page: too many links, eyes were lost looking at it. |
Jist today, someone said they wished they could download the Python tutorial as PDF or epub, not realising they're already available. Let's merge this, it's an improvement over the current situation. And we can open a new issue or PR if we wish to make further changes. |
Thanks @AA-Turner for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
…d page (pythonGH-104443) (cherry picked from commit 90cf345) Co-authored-by: Adam Turner <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
GH-109345 is a backport of this pull request to the 3.12 branch. |
GH-109346 is a backport of this pull request to the 3.11 branch. |
…d page (pythonGH-104443) (cherry picked from commit 90cf345) Co-authored-by: Adam Turner <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
…ad page (GH-104443) (#109346) Co-authored-by: Adam Turner <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
…ad page (GH-104443) (#109345) GH-104395: Add a link in 'Meta Information' to the docs download page (GH-104443) (cherry picked from commit 90cf345) Co-authored-by: Adam Turner <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
…d page (python#104443) Co-authored-by: Hugo van Kemenade <[email protected]>
📚 Documentation preview 📚: https://cpython-previews--104443.org.readthedocs.build/