Skip to content

gh-48241: Clarify URL needs to be encoded when provided to urlopen and Request #103855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 26, 2023
Merged

gh-48241: Clarify URL needs to be encoded when provided to urlopen and Request #103855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e02df13
Adding note about url needing to be encoded when provided to the urlo…
mblahay Apr 25, 2023
54345f5
📜🤖 Added by blurb_it.
blurb-it[bot] Apr 25, 2023
e36f300
Update Doc/library/urllib.request.rst
mblahay Apr 26, 2023
6dedbf8
Update Doc/library/urllib.request.rst
mblahay Apr 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Doc/library/urllib.request.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ The :mod:`urllib.request` module defines the following functions:

.. function:: urlopen(url, data=None[, timeout], *, cafile=None, capath=None, cadefault=False, context=None)

Open the URL *url*, which can be either a string or a
:class:`Request` object.
Open *url*, which can be either a string containing a valid, properly
encoded URL, or a :class:`Request` object.

*data* must be an object specifying additional data to be sent to the
server, or ``None`` if no such data is needed. See :class:`Request`
Expand Down Expand Up @@ -192,7 +192,7 @@ The following classes are provided:

This class is an abstraction of a URL request.

*url* should be a string containing a valid URL.
*url* should be a string containing a valid, properly encoded URL.

*data* must be an object specifying additional data to send to the
server, or ``None`` if no such data is needed. Currently HTTP
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Documentation/2023-04-25-22-58-08.gh-issue-48241.l1Gxxh.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Clarifying documentation about the url parameter to urllib.request.urlopen and urllib.request.Requst needing to be encoded properly.