Skip to content

gh-103224: Resolve paths properly in test_sysconfig #103292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

artemmukhin
Copy link
Contributor

@artemmukhin artemmukhin commented Apr 5, 2023

Now running tests through a Python symlink no longer causes test_nt_venv_scheme and test_posix_venv_scheme to fail.

@hroncok Thank you for helping!

To pass tests when executed through a Python symlink.

Co-authored-by: Miro Hrončok <[email protected]>
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks safe.

@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) February 6, 2024 17:25
@serhiy-storchaka serhiy-storchaka added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Feb 6, 2024
@serhiy-storchaka serhiy-storchaka changed the title GH-103224: Resolve paths properly in test_sysconfig gh-103224: Resolve paths properly in test_sysconfig Feb 6, 2024
@serhiy-storchaka serhiy-storchaka merged commit 71239d5 into python:main Feb 6, 2024
@miss-islington-app
Copy link

Thanks @artemmukhin for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 6, 2024
…03292)

To pass tests when executed through a Python symlink.

(cherry picked from commit 71239d5)

Co-authored-by: Artem Mukhin <[email protected]>
Co-authored-by: Miro Hrončok <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Feb 6, 2024

GH-115100 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Feb 6, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 6, 2024
…03292)

To pass tests when executed through a Python symlink.

(cherry picked from commit 71239d5)

Co-authored-by: Artem Mukhin <[email protected]>
Co-authored-by: Miro Hrončok <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Feb 6, 2024

GH-115101 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Feb 6, 2024
serhiy-storchaka pushed a commit that referenced this pull request Feb 7, 2024
GH-115100)

To pass tests when executed through a Python symlink.

(cherry picked from commit 71239d5)

Co-authored-by: Artem Mukhin <[email protected]>
Co-authored-by: Miro Hrončok <[email protected]>
serhiy-storchaka pushed a commit that referenced this pull request Feb 7, 2024
GH-115101)

To pass tests when executed through a Python symlink.

(cherry picked from commit 71239d5)

Co-authored-by: Artem Mukhin <[email protected]>
Co-authored-by: Miro Hrončok <[email protected]>
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
…03292)

To pass tests when executed through a Python symlink.

Co-authored-by: Miro Hrončok <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants