-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
GH-82565: Fixed a possible assertion error #103206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixed a possible assertion error
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
(void)_PyObject_LookupAttr(file, &_Py_ID(read), &self->read); | ||
(void)_PyObject_LookupAttr(file, &_Py_ID(readline), &self->readline); | ||
if (!self->readline || !self->read) { | ||
if (_PyObject_LookupAttrId(file, &PyId_read, &self->read) <= 0 || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems that you forgot to define a PyId_read
and PyId_readline
.
However, have you try to a built python with this patch manually?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have fixed this issue in the latest commit ✅
Please have a look , Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems that tests keep falling.
You sure that you made necessary changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Below changes are made by me :
All other changes are imported as it is from #16606
Therefore, I am not sure where exactly the code is failing .
Hi!
You forgot to define some identifiers, so, CI/CD fails. |
GH-82565 Fixed a possible assertion error
[bpo-38384-pickle-assert] #16606
Please check the below code test cases
File without read and readline
File with bad read and without readline
File with bad readline and without read