gh-100061: Restore the global Input Stream pointer #102612

uyw4687 · 2023-03-11T22:27:24Z

Issue: Extra characters erroneously matched when using possessive quantifier with negative lookahead #100061

ghost

Please add a new entry that describe the fix to user.
Such as: Fix wrong match in postive qualifiers. Patch by <your name>

ghost · 2023-03-12T02:50:48Z

Lib/test/test_re.py

@@ -2303,6 +2303,8 @@ def test_possessive_quantifiers(self):
        self.assertIsNone(re.match("^x{}+$", "xxx"))
        self.assertTrue(re.match("^x{}+$", "x{}"))

+        self.assertEqual(re.match('((.(?!C))++)', 'ABCD').span(), (0, 1))


You may add a comment # gh-100061 for this test-case.

Thanks, added :)

Modules/_sre/sre_lib.h

ghost · 2023-03-13T06:03:05Z

IMO the fix is fine. Just adjust some details (comment/new_entry).
Need to wait for a core developer to merge the PR.

arhadthedev · 2023-04-01T06:22:32Z

@ezio-melotti, @serhiy-storchaka (as regex experts)

serhiy-storchaka

LGTM.

Thank you for your contribution @animalize and @uyw4687.

This fixes also #106052

miss-islington · 2023-08-16T07:43:49Z

Thanks @uyw4687 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington · 2023-08-16T07:43:51Z

Sorry, @uyw4687 and @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker abd9cc52d94b8e2835322b62c29f09bb0e6fcfe9 3.12

miss-islington · 2023-08-16T07:44:04Z

Sorry, @uyw4687 and @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker abd9cc52d94b8e2835322b62c29f09bb0e6fcfe9 3.11

…essive quantifiers (pythonGH-102612) Restore the global Input Stream pointer after trying to match a sub-pattern. Co-authored-by: Ma Lin <[email protected]>. (cherry picked from commit abd9cc5) Co-authored-by: SKO <[email protected]>

bedevere-bot · 2023-08-16T07:56:24Z

GH-108003 is a backport of this pull request to the 3.12 branch.

…essive quantifiers (pythonGH-102612) Restore the global Input Stream pointer after trying to match a sub-pattern. Co-authored-by: Ma Lin <[email protected]>. (cherry picked from commit abd9cc5) Co-authored-by: SKO <[email protected]>

bedevere-bot · 2023-08-16T07:59:30Z

GH-108004 is a backport of this pull request to the 3.11 branch.

bedevere-bot · 2023-08-16T08:03:47Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 RHEL8 LTO + PGO 3.x has failed when building commit abd9cc5.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/78/builds/5080) and take a look at the build logs.
Check if the failure is related to this commit (abd9cc5) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/78/builds/5080

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

431 tests OK.

10 slowest tests:

test_concurrent_futures: 2 min 27 sec
test_multiprocessing_spawn: 1 min 59 sec
test_multiprocessing_forkserver: 1 min 16 sec
test_signal: 1 min 12 sec
test_multiprocessing_fork: 1 min 8 sec
test_socket: 42.6 sec
test_io: 40.1 sec
test_imaplib: 32.8 sec
test_subprocess: 32.3 sec
test_xmlrpc: 27.5 sec

1 test altered the execution environment:
test_interpreters

15 tests skipped:
test.test_asyncio.test_windows_events
test.test_asyncio.test_windows_utils test_devpoll test_gdb
test_ioctl test_kqueue test_launcher test_startfile test_tkinter
test_ttk test_winconsoleio test_winreg test_winsound test_wmi
test_zipfile64

Total duration: 2 min 37 sec

Click to see traceback logs

Traceback (most recent call last):
  File "<frozen importlib._bootstrap>", line 1266, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1237, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 841, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 999, in exec_module
  File "<frozen importlib._bootstrap_external>", line 1095, in get_code
  File "<frozen importlib._bootstrap_external>", line 1194, in get_data
TypeError: descriptor 'close' for '_io.BufferedReader' objects doesn't apply to a '_io.FileIO' object


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/threading.py", line 1052, in _bootstrap_inner
    self.run()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/threading.py", line 989, in run
    self._target(*self._args, **self._kwargs)
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/test/test_interpreters.py", line 481, in task
    interp = interpreters.create()
             ^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/test/support/interpreters.py", line 25, in create
    id = _interpreters.create(isolated=isolated)
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
RuntimeError: interpreter creation failed
k

… quantifiers (GH-102612) (GH-108004) Restore the global Input Stream pointer after trying to match a sub-pattern. Co-authored-by: Ma Lin <[email protected]> (cherry picked from commit abd9cc5) Co-authored-by: SKO <[email protected]>

… quantifiers (GH-102612) (#108003) Restore the global Input Stream pointer after trying to match a sub-pattern. . (cherry picked from commit abd9cc5) Co-authored-by: SKO <[email protected]>

pythongh-100061 Restore the global Input Stream pointer

007e7d7

bedevere-bot mentioned this pull request Mar 11, 2023

Extra characters erroneously matched when using possessive quantifier with negative lookahead #100061

Closed

bedevere-bot added the awaiting review label Mar 11, 2023

pythongh-100061 Refine comment

43dc3cf

hauntsaninja changed the title ~~pythongh-100061 Restore the global Input Stream pointer~~ gh-100061: Restore the global Input Stream pointer Mar 11, 2023

hauntsaninja added the needs backport to 3.11 only security fixes label Mar 11, 2023

hauntsaninja requested a review from serhiy-storchaka March 11, 2023 23:06

corona10 added the skip news label Mar 12, 2023

ghost reviewed Mar 12, 2023

View reviewed changes

pythongh-100061 Add github issue number on comments

d33c012

ghost reviewed Mar 13, 2023

View reviewed changes

Modules/_sre/sre_lib.h Show resolved Hide resolved

uyw4687 added 3 commits March 13, 2023 23:52

pythongh-100061 Remove unneeded comment

8a958f1

pythongh-100061 Refine test case

b5476e4

Add blurb entry

2ffcc16

arhadthedev added the topic-regex label Apr 1, 2023

serhiy-storchaka added 3 commits August 16, 2023 09:14

Merge branch 'main' into pythongh-100061

4c4b271

Re-enable possesive qualifiers in the commpiler.

86ca7e7

Refine tests.

6656aa2

serhiy-storchaka approved these changes Aug 16, 2023

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels Aug 16, 2023

serhiy-storchaka added needs backport to 3.12 only security fixes and removed skip news labels Aug 16, 2023

serhiy-storchaka merged commit abd9cc5 into python:main Aug 16, 2023

bedevere-bot removed the awaiting merge label Aug 16, 2023

miss-islington assigned serhiy-storchaka Aug 16, 2023

bedevere-bot removed the needs backport to 3.12 only security fixes label Aug 16, 2023

bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 16, 2023

serhiy-storchaka removed their assignment Aug 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gh-100061: Restore the global Input Stream pointer #102612

gh-100061: Restore the global Input Stream pointer #102612

uyw4687 commented Mar 11, 2023 •

edited by bedevere-bot

Loading

ghost left a comment •

edited by ghost

Loading

ghost Mar 12, 2023

uyw4687 Mar 13, 2023 •

edited

Loading

ghost commented Mar 13, 2023

arhadthedev commented Apr 1, 2023

serhiy-storchaka left a comment

miss-islington commented Aug 16, 2023

miss-islington commented Aug 16, 2023

miss-islington commented Aug 16, 2023

bedevere-bot commented Aug 16, 2023

bedevere-bot commented Aug 16, 2023

bedevere-bot commented Aug 16, 2023

gh-100061: Restore the global Input Stream pointer #102612

gh-100061: Restore the global Input Stream pointer #102612

Conversation

uyw4687 commented Mar 11, 2023 • edited by bedevere-bot Loading

ghost left a comment • edited by ghost Loading

Choose a reason for hiding this comment

ghost Mar 12, 2023

Choose a reason for hiding this comment

uyw4687 Mar 13, 2023 • edited Loading

Choose a reason for hiding this comment

ghost commented Mar 13, 2023

arhadthedev commented Apr 1, 2023

serhiy-storchaka left a comment

Choose a reason for hiding this comment

miss-islington commented Aug 16, 2023

miss-islington commented Aug 16, 2023

miss-islington commented Aug 16, 2023

bedevere-bot commented Aug 16, 2023

bedevere-bot commented Aug 16, 2023

bedevere-bot commented Aug 16, 2023

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

uyw4687 commented Mar 11, 2023 •

edited by bedevere-bot

Loading

ghost left a comment •

edited by ghost

Loading

uyw4687 Mar 13, 2023 •

edited

Loading