Skip to content

GH-101369: Allow macros as family members #101399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 30, 2023
Merged

GH-101369: Allow macros as family members #101399

merged 4 commits into from
Jan 30, 2023

Conversation

gvanrossum
Copy link
Member

Fixes gh-101369.

@markshannon: You have to use macro here:

macro(BINARY_OP_ADD_FLOAT) = _BINARY_OP_ADD_FLOAT_CHECK + _BINARY_OP_ADD_FLOAT_ACTION;

@bedevere-bot bedevere-bot mentioned this pull request Jan 28, 2023
Closed
iritkatriel
iritkatriel approved these changes Jan 29, 2023
View reviewed changes
Copy link
Member

@iritkatriel iritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gvanrossum
Copy link
Member Author

Thanks, I have a few updates in the pipeline. Will add those later.

@gvanrossum
Copy link
Member Author

This is all I was planning.

@gvanrossum gvanrossum merged commit 7a37523 into python:main Jan 30, 2023
@gvanrossum gvanrossum deleted the fix-macros-good branch January 30, 2023 19:24
mdboom pushed a commit to mdboom/cpython that referenced this pull request Jan 31, 2023
@gvanrossum @mdboom
pythonGH-101369: Allow macros as family members (python#101399)
322ee96 
Also check for instructions straddling families (this includes macro parts).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bytecode interpreter generator should support composing instructions from parts.
3 participants
@gvanrossum @iritkatriel @bedevere-bot