Fix ProgramPriorityTests on FreeBSD with high nice value #100145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProgramPriorityTests has a check for the case where process priority (nice value) cannot be increased any further because it's already at its maximal value (e.g. when tests are run with maximal niceness). It expects priority to be capped with 19, which is the cap for Linux, but for FreeBSD the cap is 20 and the test fails under the similar conditions. Tweak the condition to cover FreeBSD as well.
✅ Deploy Preview for python-cpython-preview canceled.
|
serhiy-storchaka
approved these changes
Feb 17, 2024
serhiy-storchaka
added
skip news
needs backport to 3.11
|
Thanks @AMDmi3 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 17, 2024
…0145) It expects priority to be capped with 19, which is the cap for Linux, but for FreeBSD the cap is 20 and the test fails under the similar conditions. Tweak the condition to cover FreeBSD as well. (cherry picked from commit 4379244) Co-authored-by: Dmitry Marakasov <[email protected]>
|
GH-115614 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 17, 2024
…0145) It expects priority to be capped with 19, which is the cap for Linux, but for FreeBSD the cap is 20 and the test fails under the similar conditions. Tweak the condition to cover FreeBSD as well. (cherry picked from commit 4379244) Co-authored-by: Dmitry Marakasov <[email protected]>
|
GH-115615 is a backport of this pull request to the 3.11 branch. |
serhiy-storchaka
pushed a commit
that referenced
this pull request
Feb 17, 2024
…00145) (GH-115614) It expects priority to be capped with 19, which is the cap for Linux, but for FreeBSD the cap is 20 and the test fails under the similar conditions. Tweak the condition to cover FreeBSD as well. (cherry picked from commit 4379244) Co-authored-by: Dmitry Marakasov <[email protected]>
serhiy-storchaka
pushed a commit
that referenced
this pull request
Feb 17, 2024
…00145) (GH-115615) It expects priority to be capped with 19, which is the cap for Linux, but for FreeBSD the cap is 20 and the test fails under the similar conditions. Tweak the condition to cover FreeBSD as well. (cherry picked from commit 4379244) Co-authored-by: Dmitry Marakasov <[email protected]>
woodruffw
pushed a commit
to woodruffw-forks/cpython
that referenced
this pull request
Mar 4, 2024
…0145) It expects priority to be capped with 19, which is the cap for Linux, but for FreeBSD the cap is 20 and the test fails under the similar conditions. Tweak the condition to cover FreeBSD as well.
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…0145) It expects priority to be capped with 19, which is the cap for Linux, but for FreeBSD the cap is 20 and the test fails under the similar conditions. Tweak the condition to cover FreeBSD as well.
LukasWoodtli
pushed a commit
to LukasWoodtli/cpython
that referenced
this pull request
Jan 22, 2025
…0145) It expects priority to be capped with 19, which is the cap for Linux, but for FreeBSD the cap is 20 and the test fails under the similar conditions. Tweak the condition to cover FreeBSD as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProgramPriorityTestshas a check for the case where process priority (nice value) cannot be increased any further because it's already at its maximal value (e.g. when tests are run with maximal niceness). It expects priority to be capped with 19, which is the cap for Linux, but for FreeBSD the cap is 20 and the test fails under the similar conditions. Tweak the condition to cover FreeBSD as well.I do no think this fix requires an issue or news entry.