Skip to content

Clean up typing.rst docs about Generic base classes #98623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sobolevn opened this issue Oct 24, 2022 · 1 comment
Closed

Clean up typing.rst docs about Generic base classes #98623

sobolevn opened this issue Oct 24, 2022 · 1 comment
Assignees
@sobolevn
Labels
docs Documentation in the Doc dir topic-typing

Comments

@sobolevn
Copy link
Member

There are multiple issues right now:

  1. Mapping has Mapping(Sized, Collection[KT], Generic[VT_co]) which is not correct. Typeshed's definition: class Mapping(Collection[_KT], Generic[_KT, _VT_co]):. Here we have extra Sized and wrong Generic base class with only one type argument
  2. There's also AbstractSet(Sized, Collection[T_co]), which has extra Sized. Collection is always Sized
@sobolevn sobolevn added the docs Documentation in the Doc dir label Oct 24, 2022
@sobolevn sobolevn self-assigned this Oct 24, 2022
sobolevn added a commit to sobolevn/cpython that referenced this issue Oct 24, 2022
@sobolevn
pythongh-98623: Fix base classes in typing.rst
4f38eed
@bedevere-bot bedevere-bot mentioned this issue Oct 24, 2022
Merged
JelleZijlstra pushed a commit that referenced this issue Oct 25, 2022
@sobolevn
gh-98623: Fix base classes in typing.rst (#98626)
5076108
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 25, 2022
@sobolevn @miss-islington
pythongh-98623: Fix base classes in typing.rst (pythonGH-98626)
5187c99 
(cherry picked from commit 5076108)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-bot bedevere-bot mentioned this issue Oct 25, 2022
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 25, 2022
@sobolevn @miss-islington
pythongh-98623: Fix base classes in typing.rst (pythonGH-98626)
6991bee 
(cherry picked from commit 5076108)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-bot bedevere-bot mentioned this issue Oct 25, 2022
Merged
miss-islington added a commit that referenced this issue Oct 25, 2022
@miss-islington @sobolevn
gh-98623: Fix base classes in typing.rst (GH-98626)
4b68e34 
(cherry picked from commit 5076108)

Co-authored-by: Nikita Sobolev <[email protected]>
miss-islington added a commit that referenced this issue Oct 25, 2022
@miss-islington @sobolevn
gh-98623: Fix base classes in typing.rst (GH-98626)
3e335f2 
(cherry picked from commit 5076108)

Co-authored-by: Nikita Sobolev <[email protected]>
@kamilturek
Copy link
Contributor

Looks like the issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
docs Documentation in the Doc dir topic-typing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sobolevn @kamilturek @AlexWaygood