Skip to content

sys.settrace and sys.setprofile are not re-entrant #94510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pablogsal opened this issue Jul 2, 2022 · 2 comments
Closed

sys.settrace and sys.setprofile are not re-entrant #94510

pablogsal opened this issue Jul 2, 2022 · 2 comments

Comments

@pablogsal
Copy link
Member

The code that sets trace and profile functions is not re-entrant. We are leaking objects if removing a profile/trace functions triggers a re-entrant call.

We should raise in this case.
@pablogsal pablogsal changed the title sys.settrace is not re-entrant sys.settrace and sys.setprofile are not re-entrant Jul 2, 2022
@bedevere-bot bedevere-bot mentioned this issue Jul 2, 2022
Merged
pablogsal added a commit to pablogsal/cpython that referenced this issue Jul 2, 2022
@pablogsal
pythongh-94510: Raise on re-entrant calls to sys.setprofile and sys.s…
f93fd61 
…ettrace
ambv added a commit that referenced this issue Jul 5, 2022
@pablogsal @ambv
gh-94510: Raise on re-entrant calls to sys.setprofile and sys.settrace (
40d81fd 
GH-94511)

Co-authored-by: Łukasz Langa <[email protected]>
ambv pushed a commit to ambv/cpython that referenced this issue Jul 5, 2022
@pablogsal @ambv
[3.11] pythongh-94510: Raise on re-entrant calls to sys.setprofile an…
812aa84 
…d sys.settrace (pythonGH-94511)

Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit 40d81fd)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
@bedevere-bot bedevere-bot mentioned this issue Jul 5, 2022
Merged
@bedevere-bot bedevere-bot mentioned this issue Jul 5, 2022
Merged
ambv pushed a commit to ambv/cpython that referenced this issue Jul 5, 2022
@pablogsal @ambv
[3.10] pythongh-94510: Raise on re-entrant calls to sys.setprofile an…
0e396d4 
…d sys.settrace (pythonGH-94511)

Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit 40d81fd)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
@bedevere-bot bedevere-bot mentioned this issue Jul 5, 2022
Closed
pablogsal added a commit to pablogsal/cpython that referenced this issue Jul 5, 2022
@pablogsal
[3.10] pythongh-94510: Raise on re-entrant calls to sys.setprofile an…
2f6428c 
…d sys.settrace (pythonGH-94511)

Co-authored-by: Łukasz Langa <[email protected]>.
(cherry picked from commit 40d81fd)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
pablogsal added a commit that referenced this issue Jul 5, 2022
@pablogsal
[3.10] gh-94510: Raise on re-entrant calls to sys.setprofile and syss…
5e24c80 
…ettrace (GH-94511) (#94579)

Co-authored-by: Łukasz Langa <[email protected]>.
Co-authored-by: Pablo Galindo Salgado <[email protected]>
ambv added a commit that referenced this issue Jul 5, 2022
@ambv @pablogsal
[3.11] gh-94510: Raise on re-entrant calls to sys.setprofile and sys.…
5f4a16b 
…settrace (GH-94511) (GH-94578)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit 40d81fd)
@ambv
Copy link
Contributor

ambv commented Jul 5, 2022

This is now fixed in 3.10 - 3.12. Thanks, Pablo! ✨ 🍰 ✨

@ambv ambv closed this as completed Jul 5, 2022
@vstinner vstinner mentioned this issue Oct 14, 2022
Merged
@vstinner
Copy link
Member

This change introduce a randomly failure in test_import: issue #98257.

I propose to make the function reentrant, rather than detecting and rejecting reentrant call: PR #98258.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ambv @vstinner @pablogsal