Skip to content

Remove unneeded module state from mmap module #94395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
erlend-aasland opened this issue Jun 28, 2022 · 0 comments · Fixed by #94396
Closed

Remove unneeded module state from mmap module #94395

erlend-aasland opened this issue Jun 28, 2022 · 0 comments · Fixed by #94396
Labels
3.12 only security fixes extension-modules C modules in the Modules dir type-feature A feature request or enhancement

Comments

@erlend-aasland
Copy link
Contributor

Simlar to #94394. The mmap module does not need module state. We can remove approx. 50 lines of code, and avoid allocating module state.
@erlend-aasland erlend-aasland added type-feature A feature request or enhancement extension-modules C modules in the Modules dir 3.12 only security fixes labels Jun 28, 2022
@bedevere-bot bedevere-bot mentioned this issue Jun 28, 2022
Merged
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Jun 28, 2022
@erlend-aasland
pythongh-94395: Remove unneeded module state from mmap
c6968e5
@erlend-aasland erlend-aasland linked a pull request Jun 28, 2022 that will close this issue
gh-94395: Remove unneeded module state from mmap #94396
Merged
erlend-aasland added a commit that referenced this issue Jun 29, 2022
@erlend-aasland
gh-94395: Remove unneeded module state from mmap (#94396)
79ac8c1
@erlend-aasland erlend-aasland mentioned this issue Jun 29, 2022
Closed
2 tasks
gvanrossum pushed a commit to gvanrossum/cpython that referenced this issue Jun 30, 2022
@erlend-aasland @gvanrossum
pythongh-94395: Remove unneeded module state from mmap (python#94396)
975a0cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.12 only security fixes extension-modules C modules in the Modules dir type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-94395: Remove unneeded module state from mmap erlend-aasland/cpython
1 participant
@erlend-aasland