Skip to content

Add a StreamReaderBufferedProtocol #85451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tontinton mannequin opened this issue Jul 11, 2020 · 2 comments
Open

Add a StreamReaderBufferedProtocol #85451

tontinton mannequin opened this issue Jul 11, 2020 · 2 comments

Comments

@tontinton
Copy link
Mannequin

tontinton mannequin commented Jul 11, 2020

BPO 41279
Nosy @asvetlov, @1st1, @tontinton
PRs
  • bpo-41279: Add StreamReaderBufferedProtocol #21446
  • bpo-41305: Add StreamReader.readinto() #21491
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2020-07-11.16:23:40.362>
    labels = ['expert-asyncio']
    title = 'Add a StreamReaderBufferedProtocol'
    updated_at = <Date 2020-08-29.21:19:22.551>
    user = 'https://github.com/tontinton'

    bugs.python.org fields:

    activity = <Date 2020-08-29.21:19:22.551>
    actor = 'tontinton'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['asyncio']
    creation = <Date 2020-07-11.16:23:40.362>
    creator = 'tontinton'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 41279
    keywords = ['patch']
    message_count = 2.0
    messages = ['373526', '376079']
    nosy_count = 3.0
    nosy_names = ['asvetlov', 'yselivanov', 'tontinton']
    pr_nums = ['21446', '21491']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue41279'
    versions = []

    @tontinton
    Copy link
    Mannequin Author

    tontinton mannequin commented Jul 11, 2020

    This will greatly increase performance, from my internal tests it was about 150% on linux.

    Using read_into instead of read will make it so we do not allocate a new buffer each time data is received.

    @tontinton
    Copy link
    Mannequin Author

    tontinton mannequin commented Aug 29, 2020

    bump

    @tontinton tontinton mannequin changed the title Convert StreamReaderProtocol to a BufferedProtocol Add a StreamReaderBufferedProtocol Aug 29, 2020
    @tontinton tontinton mannequin changed the title Convert StreamReaderProtocol to a BufferedProtocol Add a StreamReaderBufferedProtocol Aug 29, 2020
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @ezio-melotti ezio-melotti moved this to Todo in asyncio Jul 17, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    Status: Todo
    Development

    No branches or pull requests

    1 participant