IDLE: configdialog - add tests for ConfigDialog GUI.

[terryjreedy]

BPO	30780
Nosy	@terryjreedy, @mlouielu, @csabella, @miss-islington
PRs	bpo-30780: Fix error in idlelib.test_idle.test_configdialog #2606 [3.6] bpo-30780: Fix error in idlelib.test_idle.test_configdialog (GH… #2613 bpo-30617: IDLE: docstrings and unittest for outwin.py #2046 bpo-30780: IDLE: Fix for configdialog test with messagebox #3222 bpo-30781: IDLE: Fix help button on configdialog #3238 bpo-30780: Add IDLE configdialog tests #3592 [3.7] bpo-30780: Add IDLE configdialog tests (GH-3592) #18218 [3.8] bpo-30780: Add IDLE configdialog tests (GH-3592) #18219
Dependencies	bpo-30779: IDLE: configdialog -- factor out Changes class bpo-30870: IDLE: configdialog/fonts: change font when select by key up/down bpo-30981: IDLE: Test config dialog font bold button and sample change bpo-30993: IDLE: Document, fix, and complete configdialog font tests bpo-31001: IDLE: Add tests for configdialog highlight tab bpo-31002: IDLE: Add tests for configdialog keys tab bpo-31003: IDLE: Add tests for help sources on configdialog general tab bpo-31287: IDLE configdialog tests: don't modify tkinter.messagebox. bpo-31414: IDLE: Entry tests should delete before insert.

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/terryjreedy'
closed_at = <Date 2020-01-27.23:38:45.436>
created_at = <Date 2017-06-26.22:38:31.231>
labels = ['3.8', 'expert-IDLE', 'type-feature', '3.7', '3.9']
title = 'IDLE: configdialog - add tests for ConfigDialog GUI.'
updated_at = <Date 2020-01-27.23:38:45.434>
user = 'https://github.com/terryjreedy'

bugs.python.org fields:

activity = <Date 2020-01-27.23:38:45.434>
actor = 'terry.reedy'
assignee = 'terry.reedy'
closed = True
closed_date = <Date 2020-01-27.23:38:45.436>
closer = 'terry.reedy'
components = ['IDLE']
creation = <Date 2017-06-26.22:38:31.231>
creator = 'terry.reedy'
dependencies = ['30779', '30870', '30981', '30993', '31001', '31002', '31003', '31287', '31414']
files = []
hgrepos = []
issue_num = 30780
keywords = ['patch']
message_count = 18.0
messages = ['296963', '297016', '297247', '297250', '297838', '297852', '297853', '297855', '300906', '300922', '301037', '301849', '302171', '302225', '307206', '360810', '360815', '360816']
nosy_count = 4.0
nosy_names = ['terry.reedy', 'louielu', 'cheryl.sabella', 'miss-islington']
pr_nums = ['2606', '2613', '2046', '3222', '3238', '3592', '18218', '18219']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue30780'
versions = ['Python 3.7', 'Python 3.8', 'Python 3.9']

[terryjreedy]

A complete test of the GUI will simulate user interaction with every widget and then query Changes() to see that the proper changes orders have been recorded.

This issue depends on bpo-30779, factor out Changes class.

[terryjreedy]

Tests should be tested on MacOS before being pushed. A possible issue is including constants that are different on different systems. See bpo-28572

[mlouielu]

I'm trying to add the test on configdialog, currently working on KeysTest.

[terryjreedy]

Proceed as you want. Keep in mind that the interface to the changes structure will be changed by bpo-30779. The testing logic should not be, however.

[terryjreedy]

PR to fix type in moduleTearDown.

[terryjreedy]

New changeset 25a4206 by terryjreedy in branch 'master':
bpo-30780: Fix error in idlelib.test_idle.test_configdialog (bpo-2606)
25a4206

[terryjreedy]

I posted PR 2612 for bpo-30779 and expect to merge it tomorrow after sleep and final review. It includes passing revisions of existing configdialog tests. A PR dependent on 2612 could be posted before I do the merge.

Follow the model of using xyzpage names in asserts and tests would survive the refactoring of ConfigChanges discussed as a possibility on bpo-30779. I want to move forward on this, but not duplicate your work, so please post work done and immediate plans.

[terryjreedy]

New changeset df0f993 by terryjreedy in branch '3.6':
[3.6] bpo-30780: Fix error in idlelib.test_idle.test_configdialog (GH-2606) (bpo-2613)
df0f993

[terryjreedy]

This issue is almost done. There are just a few things missed by the closed dependencies.

[terryjreedy]

bpo-31001 and bpo-31002 have notes on what not tested in HighPage and KeysPage.

[csabella]

I've started working on the missing tests for HighPage and KeysPage and also test for the functions and buttons in ConfigDialog. That led to PR3238 because the 'help' button wasn't working.

Anyway, I found the following on http://effbot.org/tkinterbook/tkinter-events-and-bindings.htm:

"An easier solution is to prevent Tkinter from propagating the event to other handlers; just return the string “break” from your event handler:

def ignore(event):
    return "break"
text.bind("<Return>", ignore)
or

text.bind("<Return>", lambda e: "break")"

So, it seems that the 'Double-Button-1' and 'B1-Motion' bindings are to prevent those events from propagating outside of the widget. Although, I didn't notice a difference when I commented them out, so maybe they don't have a higher level binding.