Failure to compile with readline-6.3-rc1

[jhl]

BPO	20374
Nosy	@birkenfeld, @larryhastings, @benjaminp, @ned-deily, @serhiy-storchaka, @koobs
Files	readline_func_cast.patch issue20374_no_cast_33.patch: 2.7 and 3.3 issue20374_no_cast_3x.patch: default

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/ned-deily'
closed_at = <Date 2014-09-30.17:29:30.903>
created_at = <Date 2014-01-24.04:26:50.018>
labels = ['extension-modules', 'build', 'release-blocker']
title = 'Failure to compile with readline-6.3-rc1'
updated_at = <Date 2014-09-30.17:37:56.977>
user = 'https://bugs.python.org/jhl'

bugs.python.org fields:

activity = <Date 2014-09-30.17:37:56.977>
actor = 'georg.brandl'
assignee = 'ned.deily'
closed = True
closed_date = <Date 2014-09-30.17:29:30.903>
closer = 'ned.deily'
components = ['Extension Modules']
creation = <Date 2014-01-24.04:26:50.018>
creator = 'jhl'
dependencies = []
files = ['33682', '33936', '33937']
hgrepos = []
issue_num = 20374
keywords = ['patch']
message_count = 20.0
messages = ['209035', '209038', '209055', '209067', '209095', '209096', '209097', '209098', '209225', '209226', '209227', '210355', '210356', '210357', '210358', '210868', '227954', '227955', '227962', '227964']
nosy_count = 9.0
nosy_names = ['georg.brandl', 'larry', 'benjamin.peterson', 'ned.deily', 'Arfrever', 'python-dev', 'serhiy.storchaka', 'koobs', 'jhl']
pr_nums = []
priority = 'release blocker'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue20374'
versions = ['Python 2.7', 'Python 3.3', 'Python 3.4']

[jhl]

Python 2.7.6 does not compile with readline 6.3 (rc1).
It looks like the RL_FUNCTION_TYPEDEF support in Modules/readline.c is not quite complete.

The following patch works for me, both for 2.7.6 and 3.3.3.

--- a/Modules/readline.c	2013-11-10 18:36:41.000000000 +1100
+++ b/Modules/readline.c	2014-01-24 15:11:04.182417214 +1100
@@ -911,12 +911,27 @@
     rl_bind_key_in_map ('\t', rl_complete, emacs_meta_keymap);
     rl_bind_key_in_map ('\033', rl_complete, emacs_meta_keymap);
     /* Set our hook functions */
-    rl_startup_hook = (Function *)on_startup_hook;
+    rl_startup_hook =
+#if defined(_RL_FUNCTION_TYPEDEF)
+        (rl_hook_func_t *)on_startup_hook;
+#else
+        (Function *)on_startup_hook;
+#endif
 #ifdef HAVE_RL_PRE_INPUT_HOOK
-    rl_pre_input_hook = (Function *)on_pre_input_hook;
+    rl_pre_input_hook = 
+#if defined(_RL_FUNCTION_TYPEDEF)
+        (rl_hook_func_t *)on_pre_input_hook;
+#else
+        (Function *)on_pre_input_hook;
+#endif
 #endif
     /* Set our completion function */
-    rl_attempted_completion_function = (CPPFunction *)flex_complete;
+    rl_attempted_completion_function =
+#if defined(_RL_FUNCTION_TYPEDEF)
+        (rl_completion_func_t *)flex_complete;
+#else
+        (CPPFunction *)flex_complete;
+#endif
     /* Set Python word break characters */
     completer_word_break_characters =
         rl_completer_word_break_characters =

[python-dev]

New changeset 79b82ebc4fd1 by Benjamin Peterson in branch '2.7':
use new readline function types (closes bpo-20374)
http://hg.python.org/cpython/rev/79b82ebc4fd1

New changeset fb2259d9f6b4 by Benjamin Peterson in branch '3.3':
use new readline function types (closes bpo-20374)
http://hg.python.org/cpython/rev/fb2259d9f6b4

New changeset eb251e3624df by Benjamin Peterson in branch 'default':
merge 3.3 (bpo-20374)
http://hg.python.org/cpython/rev/eb251e3624df

[ned-deily]

The checked-in fixes break builds on OS X that use the Apple-supplied libedit readline compatibility layer. See, for example: http://buildbot.python.org/all/builders/AMD64%20Snow%20Leop%203.x/builds/1077/steps/compile/logs/stdio

gcc -fno-strict-aliasing -Werror=declaration-after-statement -g -O0 -Wall -Wstrict-prototypes -I./Include -I. -IInclude -I/Users/buildbot/buildarea/3.x.murray-snowleopard/build/Include -I/Users/buildbot/buildarea/3.x.murray-snowleopard/build -c /Users/buildbot/buildarea/3.x.murray-snowleopard/build/Modules/readline.c -o build/temp.macosx-10.6-x86_64-3.4-pydebug/Users/buildbot/buildarea/3.x.murray-snowleopard/build/Modules/readline.o
/Users/buildbot/buildarea/3.x.murray-snowleopard/build/Modules/readline.c: In function ‘setup_readline’:
/Users/buildbot/buildarea/3.x.murray-snowleopard/build/Modules/readline.c:1001: error: ‘rl_hook_func_t’ undeclared (first use in this function)
/Users/buildbot/buildarea/3.x.murray-snowleopard/build/Modules/readline.c:1001: error: (Each undeclared identifier is reported only once
/Users/buildbot/buildarea/3.x.murray-snowleopard/build/Modules/readline.c:1001: error: for each function it appears in.)
/Users/buildbot/buildarea/3.x.murray-snowleopard/build/Modules/readline.c:1001: error: expected expression before ‘)’ token
/Users/buildbot/buildarea/3.x.murray-snowleopard/build/Modules/readline.c:1003: error: expected expression before ‘)’ token
/Users/buildbot/buildarea/3.x.murray-snowleopard/build/Modules/readline.c:1006: error: ‘rl_completion_func_t’ undeclared (first use in this function)
/Users/buildbot/buildarea/3.x.murray-snowleopard/build/Modules/readline.c:1006: error: expected expression before ‘)’ token

[serhiy-storchaka]

What if remove casts at all? Ned, is it compiled with libedit?

[ned-deily]

Serhiy, I'm not sure I understand your question. libedit includes a GNU readline compatibility layer and that is what _readline.so builds and links with on OS X systems (with an ABI of 10.5 and later) since OS X does not ship with GNU readline. This is also the case on some BSD systems. With your patch, _readline.so again builds correctly.

[serhiy-storchaka]

With your patch, _readline.so again builds correctly.

Yes, this is what I wanted to know. Sorry for the awkward formulation.

Type casting is dangerous because it may hide the signature mismatch, which
can cause problems later in run time. It is better to rely on static type
checking if possible.

[benjaminp]

Okay then. Off we go.

[python-dev]

New changeset 5e42e5764ac6 by Benjamin Peterson in branch '2.7':
new plan: just remove typecasts (closes bpo-20374)
http://hg.python.org/cpython/rev/5e42e5764ac6

New changeset fc62fcd8e990 by Benjamin Peterson in branch '3.3':
new plan: just remove typecasts (closes bpo-20374)
http://hg.python.org/cpython/rev/fc62fcd8e990

New changeset 3c3624fec6c8 by Benjamin Peterson in branch 'default':
merge 3.3 (bpo-20374)
http://hg.python.org/cpython/rev/3c3624fec6c8