Invalid error type in math.factorial sphinx docs/docstring

[skirpichev]

Documentation says: Raises ValueError if n is not integral or is negative.
Docstring: Raise a ValueError if x is negative or non-integral.

State of art:

>>> math.factorial(1.0)
Traceback (most recent call last):
  File "<python-input-2>", line 1, in <module>
    math.factorial(1.0)
    ~~~~~~~~~~~~~~^^^^^
TypeError: 'float' object cannot be interpreted as an integer
>>> math.factorial(-1.0)
Traceback (most recent call last):
  File "<python-input-3>", line 1, in <module>
    math.factorial(-1.0)
    ~~~~~~~~~~~~~~^^^^^^
TypeError: 'float' object cannot be interpreted as an integer
>>> math.factorial(-1)
Traceback (most recent call last):
  File "<python-input-4>", line 1, in <module>
    math.factorial(-1)
    ~~~~~~~~~~~~~~^^^^
ValueError: factorial() not defined for negative values

Documentation should be fixed to state, that TypeError is raised for non-integral arguments.

Or just omit description of exceptions and reduce docs to: "Return factorial of the nonnegative integer n."

Linked PRs

• gh-133904: math.factorial documentation fix #133907
• Fix incorrect error type in math.factorial documentation (GH-133904) #133913
• [3.14] gh-133904: Fix math.factorial documentation (GH-133907) #133918
• [3.13] gh-133904: Fix math.factorial documentation (GH-133907) #133922

[StanFromIreland]

"Return factorial of the nonnegative integer n."

+1, clear as to what n should be, error should be expected otherwise.

[mkaraev]

I opened PR
#133907

[StanFromIreland]

The pr is automatically linked, you do not need to comment it.

[skirpichev]

I think, all merged.

@mkaraev, congratulations!

[mkaraev]

@skirpichev @sobolevn thank you for your help :)