-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
Remove deprecated implicit empty sequence argument for typing.TypedDict
#133823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
What do you mean exactly? #105780 added detailed deprecation notes to the API reference for |
I meant in the |
I see. Personally I think we've given enough notice for this removal in enough places, but I also don't mind if you want to add some notes there too and extend the deprecation period. It's not a huge maintenance burden for that code to hang around for a bit longer. |
How about this:
I just wanted to be sure it was fine on your side as you're a codeowner of |
Yeah that plan sounds fine by me! I don't think the syntax that was deprecated was widely used at all, and I think the pending removal was pretty well signalled |
I'm also fine with getting rid of this (and the NamedTuple equivalent) now. |
See #133822 for the NamedTuple equivalent. I'll do the TypedDict one tomorrow. |
typing.TypedDict
typing.TypedDict
…ict` (pythonGH-133864) (cherry picked from commit f91127a) Co-authored-by: Bénédikt Tran <[email protected]>
…ict` (pythonGH-133864) (cherry picked from commit f91127a) Co-authored-by: Bénédikt Tran <[email protected]>
Uh oh!
There was an error while loading. Please reload this page.
Feature or enhancement
Proposal:
It was deprecated in 3.13 but there was no removal notice in the docs: see #105570 and #105780. I don't know whether it's better to delay it a bit more just to have a deprecation notice or to first add a deprecation notice for 3.13 and 3.14, but still remove it in 3.15.
cc @AlexWaygood
Has this already been discussed elsewhere?
This is a minor feature, which does not need previous discussion elsewhere
Links to previous discussion of this feature:
No response
Linked PRs
TypedDict
#133864TypedDict
(GH-133864) #133870TypedDict
(GH-133864) #133871The text was updated successfully, but these errors were encountered: