Skip to content

Show value of UINT32_MAX in HMAC error messages #133061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
picnixz opened this issue Apr 27, 2025 · 0 comments
Closed

Show value of UINT32_MAX in HMAC error messages #133061

picnixz opened this issue Apr 27, 2025 · 0 comments
Assignees
@picnixz
Labels
3.14 new features, bugs and security fixes extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error

Comments

@picnixz
Copy link
Member

picnixz commented Apr 27, 2025 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

Following #133027 (comment) and #133027 (comment), we should avoid having the textual "UINT32_MAX" or any C constant in a user-facing error message. I however did this when I implemented one-shot HMAC.

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Linked PRs
@picnixz picnixz added 3.14 new features, bugs and security fixes extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error labels Apr 27, 2025
@picnixz picnixz self-assigned this Apr 27, 2025
@bedevere-app bedevere-app bot mentioned this issue Apr 27, 2025
Merged
picnixz added a commit that referenced this issue Apr 27, 2025
@picnixz
gh-133061: do not mention UINT32_MAX in HMAC user-facing messages (#…
1b7470f 
…133062)
@picnixz picnixz closed this as completed Apr 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@picnixz picnixz

Labels
3.14 new features, bugs and security fixes extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@picnixz