Skip to content

test_perf_profiler test failure if installed perf version string contains commit hash #132038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
itamaro opened this issue Apr 3, 2025 · 0 comments
Closed

test_perf_profiler test failure if installed perf version string contains commit hash #132038

itamaro opened this issue Apr 3, 2025 · 0 comments
Assignees
@itamaro
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@itamaro
Copy link
Contributor

itamaro commented Apr 3, 2025 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

In some installations, the installed perf version string may contain a commit hash, for example:

>perf --version
perf version 6.12.9.g242e6068fd5c

this causes the test_perf_profiler to fail with:

ValueError: invalid literal for int() with base 10: 'g242e6068fd5c'

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux

Linked PRs
@itamaro itamaro added tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error labels Apr 3, 2025
@itamaro itamaro self-assigned this Apr 3, 2025
@bedevere-app bedevere-app bot mentioned this issue Apr 3, 2025
Merged
AA-Turner pushed a commit that referenced this issue Apr 3, 2025
@itamaro
gh-132038: Make perf version check in test_perf_profiler more robust (#…
b6c92ec 
…132039)

Should work also if the version string includes a commit hash, like `perf version 6.12.9.g242e6068fd5c`
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Apr 4, 2025
@itamaro @miss-islington
pythongh-132038: Make perf version check in test_perf_profiler more r…
862e08b 
…obust (pythonGH-132039)

Should work also if the version string includes a commit hash, like `perf version 6.12.9.g242e6068fd5c`
(cherry picked from commit b6c92ec)

Co-authored-by: Itamar Oren <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Apr 4, 2025
Merged
hugovk pushed a commit that referenced this issue Apr 6, 2025
@miss-islington @itamaro
[3.13] gh-132038: Make perf version check in test_perf_profiler more …
f7ab4eb 
…robust (GH-132039) (#132058)

gh-132038: Make perf version check in test_perf_profiler more robust (GH-132039)

Should work also if the version string includes a commit hash, like `perf version 6.12.9.g242e6068fd5c`
(cherry picked from commit b6c92ec)

Co-authored-by: Itamar Oren <[email protected]>
@hugovk hugovk closed this as completed Apr 6, 2025
seehwan pushed a commit to seehwan/cpython that referenced this issue Apr 16, 2025
@itamaro @seehwan80
pythongh-132038: Make perf version check in test_perf_profiler more r…
06c85cb 
…obust (python#132039)

Should work also if the version string includes a commit hash, like `perf version 6.12.9.g242e6068fd5c`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@itamaro itamaro

Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@itamaro @hugovk