Skip to content

Update installers to use SQLite 3.49 #129917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
erlend-aasland opened this issue Feb 9, 2025 · 16 comments
Closed

Update installers to use SQLite 3.49 #129917

erlend-aasland opened this issue Feb 9, 2025 · 16 comments

Comments

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Feb 9, 2025

Proposal:

We'e been skipping some SQLite versions lately; currently we're shipping the macOS and Windows installers with SQLite 3.45.3 (released 300 days ago, 2024-04-15). SQLite 3.49.0 recently came out, so we should probably hold off upgrading for a couple of weeks to see if patch releases appear.

See also #129870.

Has this already been discussed elsewhere?

No response given

Links to previous discussion of this feature:

No response

Linked PRs

@erlend-aasland
Copy link
Contributor Author

@mhsmith, could you update the BeeWare sources repo with a tag for SQLite 3.49.0?

@erlend-aasland erlend-aasland changed the title Update macOS and Windows installers to use SQLite 3.49.0 Update installers to use SQLite 3.49.0 Feb 9, 2025
@erlend-aasland
Copy link
Contributor Author

FTR: I've updated our sources repo to SQLite 3.49.0.

@ned-deily ned-deily self-assigned this Feb 9, 2025
@ned-deily
Copy link
Member

@erlend-aasland I'll update the macOS installer builds.

@mhsmith
Copy link
Member

mhsmith commented Feb 10, 2025

@mhsmith, could you update the BeeWare sources repo with a tag for SQLite 3.49.0?

Done – the tag for android.py is sqlite-3.49.0-0.

@erlend-aasland erlend-aasland changed the title Update installers to use SQLite 3.49.0 Update installers to use SQLite 3.49 Feb 27, 2025
@erlend-aasland
Copy link
Contributor Author

3.49.1 was released 9 days ago. Let's hold it a little bit more.

@erlend-aasland
Copy link
Contributor Author

3.49.1 was released 9 days ago. Let's hold it a little bit more.

3.49.2 is on its way: https://sqlite.org/src/info/eaa2503ef699d036

@zooba
Copy link
Member

zooba commented Mar 7, 2025

It looks like those changes aren't critical, so it's probably a good time to add this into our 3.14 releases, in case we help flush out any genuine issue.

@erlend-aasland
Copy link
Contributor Author

It looks like those changes aren't critical, so it's probably a good time to add this into our 3.14 releases, in case we help flush out any genuine issue.

Sure, let's go with 3.49.1. I already updated the sources repo with the .1 patch release. @mhsmith, can you update the BeeWare sources repo again?

@mhsmith
Copy link
Member

mhsmith commented Mar 10, 2025

@erlend-aasland: Since we're planning to migrate the Android sources repo to the Python GitHub organization in the near future, I've given you write access to it. You can automatically trigger a build and release by adding a tag to the head of the main branch, in the same format as the existing tags, and pushing it to GitHub.

I've also added the release managers @Yhg1s and @hugovk, and I'll add anyone else on the core team on request.

@mhsmith
Copy link
Member

mhsmith commented Mar 11, 2025

3.49.1 had some changes which conflicted with the Android patch, so I've fixed that and built a release.

@ned-deily
Copy link
Member

The SQLite build changes between 3.45.3 and 3.49.1 have also broken the macOS installer build. I've put a "do not merge" label on the PR until I get it fixed tomorrow.

@erlend-aasland
Copy link
Contributor Author

The SQLite build changes between 3.45.3 and 3.49.1 have also broken the macOS installer build. I've put a "do not merge" label on the PR until I get it fixed tomorrow.

What's the issue?

@mhsmith
Copy link
Member

mhsmith commented Mar 13, 2025

They've completely replaced their build system (from autoconf to autosetup), so all except the simplest build scripts will need to be updated.

@ned-deily
Copy link
Member

I figured out what got broken in our macOS installer builds going from our last rev bump (3.45.3) to 3.49.1 and, yes, it was due to the autoconf to autosetup change in 3.48 (not quite as transparent a change as they believed as we were not the only downstream builders to be affected). In any case, the fixes for the macOS installer are now included in PR #131025 and I've tested them with main (3.14). They should backport OK to 3.13 and 3.12 if you decide to do so.

@erlend-aasland
Copy link
Contributor Author

Thanks, Ned!

erlend-aasland added a commit that referenced this issue Mar 31, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Mar 31, 2025
)

(cherry picked from commit 45a3ab5)

Co-authored-by: Erlend E. Aasland <[email protected]>
Co-authored-by: Ned Deily <[email protected]>
erlend-aasland added a commit that referenced this issue Mar 31, 2025
…131957)

gh-129917: Update installers to use SQLite 3.49.1 (GH-131025)

(cherry picked from commit 45a3ab5)

Co-authored-by: Erlend E. Aasland <[email protected]>
Co-authored-by: Ned Deily <[email protected]>
erlend-aasland added a commit that referenced this issue Mar 31, 2025
seehwan pushed a commit to seehwan/cpython that referenced this issue Apr 16, 2025
@erlend-aasland
Copy link
Contributor Author

I wonder if they amended the autoconf changes; the SQLite 3.49.2 changelog has this extremely vague bullet item:

Incremental improvements to the configure/make.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants