-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
Update installers to use SQLite 3.49 #129917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@mhsmith, could you update the BeeWare sources repo with a tag for SQLite 3.49.0? |
FTR: I've updated our sources repo to SQLite 3.49.0. |
@erlend-aasland I'll update the macOS installer builds. |
Done – the tag for android.py is |
3.49.1 was released 9 days ago. Let's hold it a little bit more. |
3.49.2 is on its way: https://sqlite.org/src/info/eaa2503ef699d036 |
It looks like those changes aren't critical, so it's probably a good time to add this into our 3.14 releases, in case we help flush out any genuine issue. |
Sure, let's go with 3.49.1. I already updated the sources repo with the .1 patch release. @mhsmith, can you update the BeeWare sources repo again? |
@erlend-aasland: Since we're planning to migrate the Android sources repo to the Python GitHub organization in the near future, I've given you write access to it. You can automatically trigger a build and release by adding a tag to the head of the main branch, in the same format as the existing tags, and pushing it to GitHub. I've also added the release managers @Yhg1s and @hugovk, and I'll add anyone else on the core team on request. |
3.49.1 had some changes which conflicted with the Android patch, so I've fixed that and built a release. |
The SQLite build changes between 3.45.3 and 3.49.1 have also broken the macOS installer build. I've put a "do not merge" label on the PR until I get it fixed tomorrow. |
What's the issue? |
They've completely replaced their build system (from autoconf to autosetup), so all except the simplest build scripts will need to be updated. |
I figured out what got broken in our macOS installer builds going from our last rev bump (3.45.3) to 3.49.1 and, yes, it was due to the |
Thanks, Ned! |
Co-authored-by: Ned Deily <[email protected]>
) (cherry picked from commit 45a3ab5) Co-authored-by: Erlend E. Aasland <[email protected]> Co-authored-by: Ned Deily <[email protected]>
…131957) gh-129917: Update installers to use SQLite 3.49.1 (GH-131025) (cherry picked from commit 45a3ab5) Co-authored-by: Erlend E. Aasland <[email protected]> Co-authored-by: Ned Deily <[email protected]>
…131958) (cherry picked from commit 45a3ab5) Co-authored-by: Ned Deily <[email protected]>
Co-authored-by: Ned Deily <[email protected]>
I wonder if they amended the autoconf changes; the SQLite 3.49.2 changelog has this extremely vague bullet item:
|
Proposal:
We'e been skipping some SQLite versions lately; currently we're shipping the macOS and Windows installers with SQLite 3.45.3 (released 300 days ago, 2024-04-15). SQLite 3.49.0 recently came out, so we should probably hold off upgrading for a couple of weeks to see if patch releases appear.
See also #129870.
Has this already been discussed elsewhere?
No response given
Links to previous discussion of this feature:
No response
Linked PRs
The text was updated successfully, but these errors were encountered: