Require reviews for new features

[ambv]

Feature or enhancement

Announcement:
https://discuss.python.org/t/workflow-change-coming-mandatory-reviews-on-new-features/68135

Linked PRs

• gh-126081: For PRs labeled with "type-feature", require a core review #126082

[picnixz]

@ambv Can this one be closed or do you want to test more things?

[gaogaotiantian]

I have a question about the logistics. Normally we tag type-feature on the issue, not the PR right?

[nineteendo]

The label is derived from the issue:

To ensure this label gets applied, Bedevere will be updated to do the following:

• if we open a PR,
• and that PR touches code (i.e. not only docs / tests / build / CI configuration),
• there is an issue linked to the PR,
• and that issue is not marked with a type-bug, type-crash, or type-security label,
• then Bedevere will mark this PR with the type-feature label.

[gaogaotiantian]

That makes sense, thanks!

[ambv]

The rollout will take two more weeks for the label to be automatically applied. Please see the Discourse topic for details.

[StanFromIreland]

The rollout will take two more weeks

It has been a few more than 2 weeks, I assume this can probably be closed?

[hugovk]

This is still to be done. A week in open source can take longer than seven days :)

[StanFromIreland]

Ah, I understood it as: it has been implemented, and it is just waiting for a release or something similar.