Skip to content

The JIT optimizer doesn't know about _BINARY_OP_INPLACE_ADD_UNICODE's store #125912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brandtbucher opened this issue Oct 24, 2024 · 0 comments
Closed

The JIT optimizer doesn't know about _BINARY_OP_INPLACE_ADD_UNICODE's store #125912

brandtbucher opened this issue Oct 24, 2024 · 0 comments
Labels
3.13 bugs and security fixes 3.14 bugs and security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-JIT type-bug An unexpected behavior, bug, or error

Comments

@brandtbucher
Copy link
Member

brandtbucher commented Oct 24, 2024 •
edited by bedevere-app bot
Loading

Bug report

Our abstract interpreter should have a case for _BINARY_OP_INPLACE_ADD_UNICODE, since this "special" instruction includes a store to a fast local. This can mean that the local being stored to is left with stale information (for instance, when analyzing a = ""; a += "spam" the optimizer will incorrectly assume that a still has the value "").

CC @Fidget-Spinner.

Linked PRs
@brandtbucher brandtbucher added type-bug An unexpected behavior, bug, or error interpreter-core (Objects, Python, Grammar, and Parser dirs) 3.13 bugs and security fixes 3.14 bugs and security fixes topic-JIT labels Oct 24, 2024
@bedevere-app bedevere-app bot mentioned this issue Oct 24, 2024
Merged
brandtbucher added a commit that referenced this issue Oct 28, 2024
@brandtbucher
GH-125912: Teach the JIT's optimizer about _BINARY_OP_INPLACE_ADD_UNI…
b5b0634 
…CODE (GH-125935)
picnixz pushed a commit to picnixz/cpython that referenced this issue Dec 8, 2024
@brandtbucher @picnixz
pythonGH-125912: Teach the JIT's optimizer about _BINARY_OP_INPLACE_A…
06c5b0c 
…DD_UNICODE (pythonGH-125935)
ebonnal pushed a commit to ebonnal/cpython that referenced this issue Jan 12, 2025
@brandtbucher @ebonnal
pythonGH-125912: Teach the JIT's optimizer about _BINARY_OP_INPLACE_A…
925915e 
…DD_UNICODE (pythonGH-125935)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.13 bugs and security fixes 3.14 bugs and security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-JIT type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brandtbucher