-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
Update check_generated_files CI to use our published container image #125741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Can this be closed? |
yes |
…blished container image (pythongh-125744) (cherry picked from commit ed24702) Co-authored-by: Donghee Na <[email protected]>
…blished container image (pythongh-125744) (cherry picked from commit ed24702) Co-authored-by: Donghee Na <[email protected]>
not yet; we need the backports first |
Is it documented somewhere where this image is coming from? Is there a GHA workflow producing it? One thing to keep in mind with such containers is that you become responsible for the compatibility with GH Runners, because all the actions will start being invoked inside that runtime and so the runtime must fulfill all the toolchain expectations. |
…d container image (gh-125744) (#125759) (cherry picked from commit ed24702) Co-authored-by: Donghee Na <[email protected]>
…d container image (gh-125744) (#125760) (cherry picked from commit ed24702) Co-authored-by: Donghee Na <[email protected]>
…job (pythonGH-125772) (cherry picked from commit f36d37b) Co-authored-by: Adam Turner <[email protected]>
… job (GH-125772) (#125779) (cherry picked from commit f36d37b) Co-authored-by: Adam Turner <[email protected]>
…job (pythonGH-125772) (cherry picked from commit f36d37b) Co-authored-by: Adam Turner <[email protected]>
… job (GH-125772) (#130229) Co-authored-by: Adam Turner <[email protected]>
Final backports just merged, closing. Please re-open if there's more to do :) |
We can do this through https://docs.github.com/en/actions/writing-workflows/choosing-where-your-workflow-runs/running-jobs-in-a-container, and it is less painful to make both image environments the same.
See: #122566 (review)
cc @erlend-aasland @hugovk @Damien-Chen
Linked PRs
build.yml
for the new check_autoconf_regen job #125772build.yml
for the new check_autoconf_regen job (GH-125772) #125779build.yml
for the new check_autoconf_regen job (GH-125772) #130229The text was updated successfully, but these errors were encountered: