Skip to content

Free-threaded builds with PGO fail to build on Windows #123153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mdboom opened this issue Aug 19, 2024 · 2 comments
Closed

Free-threaded builds with PGO fail to build on Windows #123153

mdboom opened this issue Aug 19, 2024 · 2 comments
Labels
OS-windows topic-free-threading type-bug An unexpected behavior, bug, or error

Comments

@mdboom
Copy link
Contributor

mdboom commented Aug 19, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

I don't consider this a high-priority bug, since free threading remains experimental, however it does prevent us from getting accurate benchmarking figures for free-threaded builds on Windows.

Building with

PCbuild\build.bat --pgo   --disable-gil -c Release

currently fails with an internal compiler error:

C:\actions-runner\_work\benchmarking\benchmarking\cpython\Python\ceval.c(761): fatal error C1001: Internal compiler error. [C:\actions-runner\_work\benchmarking\benchmarking\cpython\PCbuild\pythoncore.vcxproj]
(compiler file 'D:\a\_work\1\s\src\vctools\Compiler\Utc\src\p2\main.c', line 224)
    To work around this problem, try simplifying or changing the program near the locations listed above.
   If possible please provide a repro here: https://developercommunity.visualstudio.com 
   Please choose the Technical Support command on the Visual C++ 
    Help menu, or open the Technical Support help file for more information
     link!InvokeCompilerPass()+0x10e636
     link!InvokeCompilerPass()+0x10e636
     link!InvokeCompilerPass()+0x10e373
     link!InvokeCompilerPass()+0x10b310
     link!InvokeCompilerPass()+0x10b215
     link!InvokeCompilerPass()+0x102cea

Full build log here

CPython versions tested on:

CPython main branch

Operating systems tested on:

Windows

Linked PRs
@mdboom mdboom added type-bug An unexpected behavior, bug, or error OS-windows topic-free-threading labels Aug 19, 2024
@colesbury
Copy link
Contributor

Given that it's an Internal compiler error, maybe worth reporting the bug to Visual Studio?

@mdboom
Copy link
Contributor Author

mdboom commented Aug 19, 2024

Given that it's an Internal compiler error, maybe worth reporting the bug to Visual Studio?

Sorry, I should have said so, but I plan to.

@mdboom mdboom mentioned this issue Aug 28, 2024
Closed
@mdboom mdboom mentioned this issue Oct 10, 2024
Closed
mdboom added a commit to mdboom/cpython that referenced this issue Oct 16, 2024
@mdboom
pythongh-123153: Fix PGO builds with free-threading
d4f661e
@bedevere-app bedevere-app bot mentioned this issue Oct 16, 2024
Merged
mdboom added a commit that referenced this issue Oct 17, 2024
@mdboom
gh-123153: Fix PGO builds with free-threading on Windows (#125607)
37986e8 
* gh-123153: Fix PGO builds with free-threading

* Redo how the #define works
@mdboom mdboom closed this as completed Oct 18, 2024
@mdboom mdboom mentioned this issue Nov 22, 2024
Closed
ebonnal pushed a commit to ebonnal/cpython that referenced this issue Jan 12, 2025
@mdboom @ebonnal
pythongh-123153: Fix PGO builds with free-threading on Windows (pytho…
959c396 
…n#125607)

* pythongh-123153: Fix PGO builds with free-threading

* Redo how the #define works
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OS-windows topic-free-threading type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mdboom @colesbury