-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
Minor error in the doc for controller.name in the webbrowser documentation page #122399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Would you be willing to open a PR? A |
This is a minor change that addresses python#122399 It just mentions that the controller object has a `name` attribute too, before mentioning it with the other methods.
@AA-Turner Sure! I just did in #122407 . It turns out that for the documentation in dev, the main part was already changed (webbrowser -> controller). So I just added the second part (mentioning the name attribute). |
…ts of controller object This is a minor change that addresses python#122399 (for the 3.12 branch). It fixes the reference to the attribute `name` so it belongs to the controller object (and not to the webbrowser module). It also mentions that the controller object has a name attribute too, before mentioning it with the other methods.
And this is the PR with the complete change for the branch with the last stable release (3.12): #122410 |
#105546 fixed controller.name but wasn't backported for obvious reasons. A |
…ontroller object (#122407) Co-authored-by: Adam Turner <[email protected]>
…s of controller object (pythonGH-122407) (cherry picked from commit 1583f9c) Co-authored-by: Jordi Burguet-Castell <[email protected]> Co-authored-by: Adam Turner <[email protected]>
…ts of controller object (GH-122407) (#132874) Co-authored-by: Jordi Burguet-Castell <[email protected]> Co-authored-by: Adam Turner <[email protected]>
Documentation
In https://docs.python.org/3/library/webbrowser.html#browser-controller-objects it says:
when it should be
controller
instead ofwebbrowser
(it is the controller object that has thename
attribute, not the webbrowser module).In addition to that, I think that the first sentence,
would probably be better with something like:
Thanks!
Linked PRs
The text was updated successfully, but these errors were encountered: