Skip to content

Typos in the Py_DEBUG macro name #122270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
serhiy-storchaka opened this issue Jul 25, 2024 · 0 comments
Closed

Typos in the Py_DEBUG macro name #122270

serhiy-storchaka opened this issue Jul 25, 2024 · 0 comments
Labels
3.12 only security fixes 3.13 bugs and security fixes 3.14 bugs and security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-parser type-bug An unexpected behavior, bug, or error

Comments

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Jul 25, 2024 •
edited by bedevere-app bot
Loading

Bug report

Parser/pegen.c and Tools/peg_generator/peg_extension/peg_extension.c contain checks for wrong macro:

#if defined(PY_DEBUG)

They always false, because the correct name is Py_DEBUG, not PY_DEBUG. Therefore, the code which was supposed to run in the debug build, is never compiled code.

cc @pablogsal

Linked PRs
@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error interpreter-core (Objects, Python, Grammar, and Parser dirs) 3.12 only security fixes 3.13 bugs and security fixes topic-parser 3.14 bugs and security fixes labels Jul 25, 2024
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Jul 25, 2024
@serhiy-storchaka
pythongh-122270: Fix typos in the Py_DEBUG macro name
a64330d
@bedevere-app bedevere-app bot mentioned this issue Jul 25, 2024
Merged
serhiy-storchaka added a commit that referenced this issue Jul 25, 2024
@serhiy-storchaka
gh-122270: Fix typos in the Py_DEBUG macro name (GH-122271)
6c09b8d
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 25, 2024
@serhiy-storchaka @miss-islington
pythongh-122270: Fix typos in the Py_DEBUG macro name (pythonGH-122271)
1057110 
(cherry picked from commit 6c09b8d)

Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 25, 2024
@serhiy-storchaka @miss-islington
pythongh-122270: Fix typos in the Py_DEBUG macro name (pythonGH-122271)
c89aa4a 
(cherry picked from commit 6c09b8d)

Co-authored-by: Serhiy Storchaka <[email protected]>
This was referenced Jul 25, 2024
Merged
Merged
serhiy-storchaka added a commit that referenced this issue Jul 25, 2024
@miss-islington @serhiy-storchaka
[3.12] gh-122270: Fix typos in the Py_DEBUG macro name (GH-122271) (G…
02c19f0 
…H-122276)

(cherry picked from commit 6c09b8d)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this issue Jul 25, 2024
@miss-islington @serhiy-storchaka
[3.13] gh-122270: Fix typos in the Py_DEBUG macro name (GH-122271) (G…
83bfc5b 
…H-122275)

(cherry picked from commit 6c09b8d)

Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.12 only security fixes 3.13 bugs and security fixes 3.14 bugs and security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-parser type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@serhiy-storchaka