Skip to content

email: documenting different behavior of trailing newline in set_content and set_payload #121542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ZeroIntensity opened this issue Jul 9, 2024 · 0 comments
Closed

email: documenting different behavior of trailing newline in set_content and set_payload #121542

ZeroIntensity opened this issue Jul 9, 2024 · 0 comments
Labels
docs Documentation in the Doc dir stdlib Python modules in the Lib dir topic-email

Comments

@ZeroIntensity
Copy link
Member

ZeroIntensity commented Jul 9, 2024 •
edited by bedevere-app bot
Loading

Documentation

See #121515, which reported that set_content() implicitly adds a newline to the end of the content (if it doesn't have one already), whereas set_payload() ignores it. Unfortunately, this would be a breaking change to fix, so we should just document this behavior.

Linked PRs
@ZeroIntensity ZeroIntensity added the docs Documentation in the Doc dir label Jul 9, 2024
@ZeroIntensity ZeroIntensity mentioned this issue Jul 9, 2024
Merged
@aisk aisk added stdlib Python modules in the Lib dir topic-email labels Jul 9, 2024
Eclips4 pushed a commit that referenced this issue Jan 18, 2025
@ZeroIntensity @rapidcow
gh-121542: Document trailing newline behavior in set_content() (#12…
fba475a 
…1543)

Co-authored-by: Yizheng Meng <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jan 18, 2025
@ZeroIntensity @rapidcow @miss-islington
pythongh-121542: Document trailing newline behavior in set_content() (
d16beb2 
pythonGH-121543)

(cherry picked from commit fba475a)

Co-authored-by: Peter Bierma <[email protected]>
Co-authored-by: Yizheng Meng <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jan 18, 2025
@ZeroIntensity @rapidcow @miss-islington
pythongh-121542: Document trailing newline behavior in set_content() (
dd47421 
pythonGH-121543)

(cherry picked from commit fba475a)

Co-authored-by: Peter Bierma <[email protected]>
Co-authored-by: Yizheng Meng <[email protected]>
This was referenced Jan 18, 2025
Merged
Merged
@Eclips4 Eclips4 closed this as completed Jan 18, 2025
Eclips4 pushed a commit that referenced this issue Jan 18, 2025
@miss-islington @ZeroIntensity @rapidcow
[3.13] gh-121542: Document trailing newline behavior in `set_content(…
b7ddcc3 
…)` (GH-121543) (#128995)

gh-121542: Document trailing newline behavior in `set_content()` (GH-121543)
(cherry picked from commit fba475a)

Co-authored-by: Peter Bierma <[email protected]>
Co-authored-by: Yizheng Meng <[email protected]>
Eclips4 pushed a commit that referenced this issue Jan 18, 2025
@miss-islington @ZeroIntensity @rapidcow
[3.12] gh-121542: Document trailing newline behavior in `set_content(…
104d37a 
…)` (GH-121543) (#128996)

gh-121542: Document trailing newline behavior in `set_content()` (GH-121543)
(cherry picked from commit fba475a)

Co-authored-by: Peter Bierma <[email protected]>
Co-authored-by: Yizheng Meng <[email protected]>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this issue Jan 21, 2025
@ZeroIntensity @rapidcow @srinivasreddy
pythongh-121542: Document trailing newline behavior in set_content() (
eee05c5 
python#121543)

Co-authored-by: Yizheng Meng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Documentation in the Doc dir stdlib Python modules in the Lib dir topic-email
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aisk @ZeroIntensity @Eclips4